From c702092a2206eea96d2511d6ae4dfef04ce07b0c Mon Sep 17 00:00:00 2001 From: Christian Kujau Date: Sat, 6 Jan 2024 20:38:13 +0100 Subject: [PATCH] du_multidirs: Fix up some shellcheck warnings Signed-off-by: Christian Kujau --- munin/plugins/du_multidirs | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/munin/plugins/du_multidirs b/munin/plugins/du_multidirs index d8c5fd3..5f019fb 100755 --- a/munin/plugins/du_multidirs +++ b/munin/plugins/du_multidirs @@ -13,8 +13,8 @@ if [ "$1" = "autoconf" ]; then exit 0 fi -if [ ! -f "$CACHE" ]; then - echo "Cache $CACHE not found!" +if [ ! -f "${CACHE}" ]; then + echo "Cache ${CACHE} not found!" exit 1 fi @@ -29,14 +29,13 @@ if [ "$1" = "config" ]; then # Munin doesn't like slashes, dots, hyphens and pretty much any symbols in # its variables. - awk -F\ '!/lost\+found/ {print $2}' $CACHE | sort | while read u; do - u2=`echo "$u" | sed 's/[[:punct:]]/_/g;s/ /_/g'` - echo "$u2".label $u -# echo "$u2".warning 0 -# echo "$u2".critical 0 + awk -F\ '!/lost\+found/ {print $2}' "${CACHE}" | sort | while read -r u; do + u2=$(echo "${u}" | sed 's/[[:punct:]]/_/g;s/ /_/g') + echo "${u2}".label "${u}" +# echo "${u2}".warning 0 +# echo "${u2}".critical 0 done exit 0 fi -awk '!/lost\+found/ {gsub(/\//,"_"); print $2".value "$1 * 1024 }' $CACHE | sort -r -n -k2 -# awk -F\ '!/lost+found/ {print $2".value "$1 * 1024 }' $CACHE | sed 's/[[:punct:]]/_/g' | sort -r -n -k2 +awk '!/lost\+found/ {gsub(/\//,"_"); print $2".value "$1 * 1024 }' "${CACHE}" | sort -r -n -k2