Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out long term role of ValueHint #5764

Open
epage opened this issue Oct 2, 2024 · 0 comments
Open

Figure out long term role of ValueHint #5764

epage opened this issue Oct 2, 2024 · 0 comments
Labels
A-completion Area: completion generator M-breaking-change Meta: Implementing or merging this will introduce a breaking change. S-waiting-on-design Status: Waiting on user-facing design to be resolved before implementing
Milestone

Comments

@epage
Copy link
Member

epage commented Oct 2, 2024

ValueHint works well for ahead-of-time generated completions as it tells the generator what shell behavior to opt-in to.

However, its not really needed with Rust-native completions and actually puts more of a support burden on it.

On top of that, the documentation default is less relevant now that we have typed values. We changed it for Rust-native completions in #5763 as that is still unstable.

@epage epage added M-breaking-change Meta: Implementing or merging this will introduce a breaking change. A-completion Area: completion generator S-waiting-on-design Status: Waiting on user-facing design to be resolved before implementing labels Oct 2, 2024
@epage epage added this to the 5.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-completion Area: completion generator M-breaking-change Meta: Implementing or merging this will introduce a breaking change. S-waiting-on-design Status: Waiting on user-facing design to be resolved before implementing
Projects
None yet
Development

No branches or pull requests

1 participant