fix: only allow ascii characters for name fields

watusi for example has a weird ascii character in its name, so we need to strip this out

Author: claration

crates/core/src/utils/mod.rs

@@ -9,6 +9,6 @@ pub use certificate::CertificateIdentity;
 pub fn strip_invalid_name_chars(name: &str) -> String {
     let invalid_chars = ['\\', '/', ':', '*', '?', '"', '<', '>', '|', '.'];
     name.chars()
-        .filter(|c| !invalid_chars.contains(c))
+        .filter(|c| !invalid_chars.contains(c) && !c.is_control() && c.is_ascii())
         .collect()
 }

crates/utils/src/device.rs

@@ -140,7 +140,8 @@ impl Device {
         fs::symlink(PathBuf::from("Wrapper").join(app_name), &wrapped_bundle_path).await?;
 
         let applications_dir = PathBuf::from("/Applications").join(app_name);
-        fs::rename(&outer_app_dir, &applications_dir).await?;
+        fs::rename(&outer_app_dir, &applications_dir).await
+            .map_err(|_| Error::BundleFailedToCopy(applications_dir.to_string_lossy().into_owned()))?;
 
         Ok(())
     }

crates/utils/src/lib.rs

@@ -21,6 +21,11 @@ use thiserror::Error as ThisError;
 pub enum Error {
     #[error("Info.plist not found")]
     BundleInfoPlistMissing,
+    
+    // MARK: - Device errors
+    #[error("Bundle failed to rename, make sure its available: {0}")]
+    BundleFailedToCopy(String),
+
     #[error("Zip error: {0}")]
     Zip(#[from] zip::result::ZipError),
     #[error("Info.plist not found")]