#20 - Add unit tests for EntityManager-related tasks

Author: xmarchegay

GEMINI.md

@@ -0,0 +1,82 @@
+# Gemini Code Assistant Context
+
+## Project Overview
+
+This project is a Symfony bundle named `CleverAge/DoctrineProcessBundle`. It is part of the `CleverAge/ProcessBundle` ecosystem and provides Doctrine ORM integration for data processing tasks. The bundle allows developers to create and configure ETL-like processes (Extract, Transform, Load) that can read from and write to a database using Doctrine entities.
+
+The core of the bundle is a set of "tasks" that can be chained together in a process. These tasks include:
+
+*   **Reading:** Fetching entities from the database based on criteria.
+*   **Writing:** Creating or updating entities.
+*   **Batch Writing:** Writing entities in batches for better performance.
+*   **Removing:** Deleting entities.
+*   **Cleaning/Detaching:** Managing the Doctrine entity manager's identity map.
+
+The bundle is built for Symfony and integrates with the Doctrine project.
+
+## Building and Running
+
+The project uses Docker for its development environment. The following commands are available in the `Makefile`:
+
+*   **`make start`**: Starts the Docker containers for the development environment.
+*   **`make stop`**: Stops the Docker containers.
+*   **`make bash`**: Opens a bash shell inside the PHP container.
+
+### Dependencies
+
+PHP dependencies are managed with Composer. To install them, run:
+
+```bash
+make src/vendor
+```
+
+This is typically done as part of the `make start` or `make up` commands.
+
+### Testing
+
+The project uses PHPUnit for testing. To run the test suite:
+
+```bash
+make tests
+```
+or
+```bash
+make phpunit
+```
+
+### Quality and Linting
+
+The project has a set of quality tools to ensure code standards. The main command is:
+
+```bash
+make quality
+```
+
+This command runs the following tools:
+
+*   **PHPStan**: Static analysis to find potential bugs.
+    ```bash
+    make phpstan
+    ```
+*   **PHP-CS-Fixer**: Enforces a consistent coding style.
+    ```bash
+    make php-cs-fixer
+    ```
+*   **Rector**: Provides automated refactoring to improve code quality.
+    ```bash
+    make rector
+    ```
+
+## Development Conventions
+
+### Coding Style
+
+The project follows the official Symfony coding standards, as enforced by the `.php-cs-fixer.dist.php` configuration. It uses the `@Symfony` and `@DoctrineAnnotation` rule sets. All files should include a license header.
+
+### Branching and Commits
+
+While not explicitly defined in the repository, a standard Git flow (e.g., feature branches, pull requests) is expected, as indicated by the presence of a `PULL_REQUEST_TEMPLATE.md`.
+
+### Documentation
+
+The `docs` directory contains user-facing documentation for the bundle and its tasks. When adding a new task, it should be documented in a corresponding `.md` file.

src/Task/EntityManager/DoctrineBatchWriterTask.php

@@ -72,7 +72,7 @@ protected function writeBatch(ProcessState $state): void
                 throw new \UnexpectedValueException("No manager found for class {$class}");
             }
             $entityManager->persist($entity);
-            $entityManagers->attach($entityManager);
+            $entityManagers->offsetSet($entityManager);
         }
 
         foreach ($entityManagers as $entityManager) {

tests/Task/EntityManager/AbstractDoctrineQueryTaskTest.php

@@ -0,0 +1,39 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the CleverAge/DoctrineProcessBundle package.
+ *
+ * Copyright (c) Clever-Age
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace CleverAge\DoctrineProcessBundle\Tests\Task\EntityManager;
+
+use CleverAge\DoctrineProcessBundle\Task\EntityManager\AbstractDoctrineQueryTask;
+use Doctrine\ORM\EntityManagerInterface;
+use Doctrine\ORM\EntityRepository;
+use Doctrine\ORM\QueryBuilder;
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\TestCase;
+
+#[CoversClass(AbstractDoctrineQueryTask::class)]
+class AbstractDoctrineQueryTaskTest extends TestCase
+{
+    public function testGetQueryBuilderWithInvalidField(): void
+    {
+        $this->expectException(\UnexpectedValueException::class);
+
+        $task = $this->createStub(AbstractDoctrineQueryTask::class);
+        $repository = $this->createStub(EntityRepository::class);
+        $repository->method('createQueryBuilder')->willReturn(new QueryBuilder($this->createStub(EntityManagerInterface::class)));
+
+        $reflection = new \ReflectionClass(AbstractDoctrineQueryTask::class);
+        $method = $reflection->getMethod('getQueryBuilder');
+
+        $method->invoke($task, $repository, ['e.field; DROP TABLE dummy;' => 'value'], []);
+    }
+}

tests/Task/EntityManager/ClearEntityManagerTaskTest.php

@@ -0,0 +1,52 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the CleverAge/DoctrineProcessBundle package.
+ *
+ * Copyright (c) Clever-Age
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace CleverAge\DoctrineProcessBundle\Tests\Task\EntityManager;
+
+use CleverAge\DoctrineProcessBundle\Task\EntityManager\ClearEntityManagerTask;
+use CleverAge\ProcessBundle\Model\ProcessState;
+use Doctrine\ORM\EntityManagerInterface;
+use Doctrine\Persistence\ManagerRegistry;
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\TestCase;
+
+#[CoversClass(ClearEntityManagerTask::class)]
+class ClearEntityManagerTaskTest extends TestCase
+{
+    public function testExecute(): void
+    {
+        $entityManager = $this->createMock(EntityManagerInterface::class);
+        $entityManager->expects($this->once())
+            ->method('clear');
+
+        $managerRegistry = $this->createMock(ManagerRegistry::class);
+        $managerRegistry->expects($this->once())
+            ->method('getManager')
+            ->willReturn($entityManager);
+
+        $task = $this->getMockBuilder(ClearEntityManagerTask::class)
+            ->setConstructorArgs([$managerRegistry])
+            ->onlyMethods(['getOption']) // Mock only the getOption method
+            ->getMock();
+
+        // Ensure getOption returns null for 'entity_manager', mimicking default behavior
+        $task->expects($this->once())
+            ->method('getOption')
+            ->with(self::anything(), 'entity_manager')
+            ->willReturn(null);
+
+        $processState = $this->createStub(ProcessState::class);
+
+        $task->execute($processState);
+    }
+}