-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Open
Description
Hello, I have seen one possible bug in the tensorflow C&W2 implementation.
The targeted parameter does not pass to function body, instead it is defined with respect to y parameter being None or not. This causes problems when labels are explicitly given in untargeted scenario.
| targeted=False, |
| self.targeted = y is not None |
There might be two ways to fix this:
- One would be
self.targeted = targeted - The other solution would be replacing default value of targeted to None and fixing line
targeted = None
on the argument list and
if targeted is not None:
self.targeted=targeted
else:
self.targeted = y is not None
in the body
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels