Skip to content

Commit 9af62bd

Browse files
Merge pull request #48 from clj-codes/fix/author-mobile-improvements
fix(author): mobile improvements
2 parents c00d1f9 + 79179cb commit 9af62bd

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

src/codes/clj/docs/frontend/panels/author/view.cljs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,12 @@
2020
($ List {:listStyleType "square"}
2121
(map (fn [item]
2222
($ (-> List .-Item) {:key (id-key item)}
23-
($ Box {:w #js {:base 350 :xs 400 :sm 600 :md 800 :lg 900 :xl 1000}}
23+
($ Box {:w #js {:base 300 :xs 400 :sm 600 :md 800 :lg 900 :xl 1000}}
2424
($ Text {:id (id-key item) :className "social-preview-item"
2525
:truncate "end"}
26-
(data-key item)))))
26+
(if (= data-key :definition-id-to)
27+
(str/replace (data-key item) #"/0$" "")
28+
(data-key item))))))
2729
items))))
2830

2931
(defnc author-socials-preview-list [{:keys [socials]}]
@@ -80,7 +82,7 @@
8082
($ Center
8183
($ Group {:wrap "nowrap"}
8284
($ Avatar {:src avatar-url
83-
:size 200
85+
:size "xl"
8486
:radius 200})
8587
(dom/div
8688
($ Title {:order 3}
@@ -89,15 +91,13 @@
8991
($ Text {:fz "xs" :tt "uppercase" :fw 700 :c "dimmed"}
9092
(name account-source))
9193

92-
($ Space {:h "sm"})
93-
9494
($ Text {:data-testid "author-social-summary"
9595
:fz "lg" :fw 500}
9696
(author.adapters/->string-summary value)))))
9797

9898
($ Space {:h "lg"})
9999

100-
(when socials
100+
(when (seq socials)
101101
($ author-socials-preview-list {:socials socials}))
102102

103103
($ back-to-top)))))))

test/codes/clj/docs/frontend/test/panels/author/view_test.cljs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,15 @@
3131
items (tl/wait-for #(.findByTestId ^js/Object view "author-grid"))]
3232

3333
(is (= [";;assoc applied to a vector\n\n(def my-vec [1 2 5 6 8 9])\n\n(assoc my-vec 0 77)\n;;[77 2 5 6 8 9]"
34-
"org.clojure/clojure/clojure.core/dissoc/0"
35-
"org.clojure/clojure/clojure.core/update/0"
36-
"org.clojure/clojure/clojure.core/assoc-in/0"
34+
"org.clojure/clojure/clojure.core/dissoc"
35+
"org.clojure/clojure/clojure.core/update"
36+
"org.clojure/clojure/clojure.core/assoc-in"
3737
"Here is a version that will create a vector when the key is numerical. This may be useful instead of throwing an IndexOutOfBoundsException.\n```clojure\n(defn assoc-in-idx [m [k & ks] v]\n (let [value (get m k (when (number? (first ks)) []))\n m (if (and (vector? m) (number? k) (-> m count (< k)))\n (reduce (fn [m _] (conj m nil)) m (range (count m) k))\n m)\n v (if ks\n (assoc-in-idx value ks v)\n v)]\n (assoc m k v)))\n```\n> copied from [clojuredocs.org](https://clojuredocs.org/clojure.core/assoc) for test"
3838
"; removes nil from list or vector\n(keep identity [:a :b nil :d nil :f])\n; => (:a :b :d :f)"
39-
"org.clojure/clojure/clojure.core/remove/0"
39+
"org.clojure/clojure/clojure.core/remove"
4040
"; 6 random integers (from 0 to 60)\n(take 6 (repeatedly #(rand-int 60)))"
41-
"org.clojure/clojure/clojure.core/repeatedly/0"
42-
"org.clojure/clojure/clojure.core/keep/0"]
41+
"org.clojure/clojure/clojure.core/repeatedly"
42+
"org.clojure/clojure/clojure.core/keep"]
4343
(->> (.querySelectorAll items ".social-preview-item")
4444
(map #(-> % .-textContent)))))
4545

0 commit comments

Comments
 (0)