-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
paredit join of two lists always creates vector #321
Comments
Thanks for the issue, @openvest! I've got a bunch of paredit fixes in the hopper, and this happens to be one of them! |
My wip takes the seq type on the left. My thinking is you are joining the right into the left. The left type wins. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
1.1.48
Symptom
joining two vectors works fine.
joining two lists returns a vector not a list
Reproduction
Diagnosis
The source for paredit/join appears to have :vector hard coded in.
Action
Maybe just take the tag type of the right. Also maybe ensure they are both of the same tag type?
Less of a concern is that if there is not a whitespace, it appears to merge the two items e.g. [[foo][bar]] comes back as [[foobar]] not [[foo bar]].
I can git up a pr on this but I don't know if you would consider it a breaking change for some things.
Thx again repl-balance is near feature complete on paredit thanks to rewrite-clj!
The text was updated successfully, but these errors were encountered: