Skip to content

Commit 8787fbe

Browse files
authored
CI - Fix "Check that packages are publishable" check (#3660)
# Description of Changes Our `Check that packages are publishable` CI check was silently failing due to a subshell error not getting propagated upward. This PR both fixes that error-swallowing behavior, and fixes the errors that were present. # API and ABI breaking changes No. CI only. # Expected complexity level and risk 1 # Testing - [x] Check fails if the script to find crates fails (https://github.com/clockworklabs/SpacetimeDB/actions/runs/19349995837/job/55359458732?pr=3660) - [x] Check is now passing --------- Co-authored-by: Zeke Foppa <[email protected]>
1 parent a5602a3 commit 8787fbe

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -231,11 +231,12 @@ jobs:
231231
venv/bin/pip3 install argparse toml
232232
- name: Run checks
233233
run: |
234+
set -ueo pipefail
234235
FAILED=0
235-
# This definition of ROOTS and invocation of find-publish-list.py is copied from publish-crates.sh
236-
ROOTS=(bindings sdk cli standalone)
237-
for crate in $(venv/bin/python3 tools/find-publish-list.py --recursive --quiet "${ROOTS[@]}"); do
238-
if ! venv/bin/python3 tools/crate-publish-checks.py "crates/$crate"; then
236+
ROOTS=(spacetimedb spacetimedb-sdk)
237+
CRATES=$(venv/bin/python3 tools/find-publish-list.py --recursive --directories --quiet "${ROOTS[@]}")
238+
for crate_dir in $CRATES; do
239+
if ! venv/bin/python3 tools/crate-publish-checks.py "${crate_dir}"; then
239240
FAILED=$(( $FAILED + 1 ))
240241
fi
241242
done

0 commit comments

Comments
 (0)