Windows - Set linker = "lld-link" (#3406)

# Description of Changes

See the inline comments for the motivation. This was originally
introduced to our Windows CI in #3351. This PR moves it from CI to
general Windows target builds, since it seems like Windows builds are
now generally having this issue.

# API and ABI breaking changes

None

# Expected complexity level and risk

1

# Testing

- [x] Windows CI still passes

---------

Co-authored-by: Zeke Foppa <[email protected]>

Author: bfops

.cargo/config.toml

@@ -3,3 +3,10 @@ rustflags = ["--cfg", "tokio_unstable"]
 
 [alias]
 bump-versions = "run -p upgrade-version --"
+
+[target.x86_64-pc-windows-msvc]
+# Use a different linker. Otherwise, the build fails with some obscure linker error that
+# seems to be a result of us producing a massive PDB file.
+# I (@bfops) tried a variety of other link options besides switching linkers, but this
+# seems to be the only thing that worked.
+linker = "lld-link"

.github/workflows/ci.yml

@@ -58,12 +58,6 @@ jobs:
           $ErrorActionPreference = 'Stop'
           $PSNativeCommandUseErrorActionPreference = $true
 
-          # Use a different linker. Otherwise, the build fails with some obscure linker error that
-          # seems to be a result of us producing a massive PDB file.
-          # I (@bfops) tried a variety of other link options besides switching linkers, but this
-          # seems to be the only thing that worked.
-          $env:RUSTFLAGS='-Clinker=lld-link'
-
           cargo build -p spacetimedb-cli -p spacetimedb-standalone -p spacetimedb-update
           Start-Process target/debug/spacetimedb-cli.exe -ArgumentList 'start --pg-port 5432'
           cd modules