Apply suggestions from code review

Co-authored-by: Phoebe Goldman <[email protected]>
Signed-off-by: Mario Montoya <[email protected]>

Author: mamcx

crates/cli/src/subcommands/generate/rust.rs

@@ -1317,7 +1317,7 @@ impl DbConnection {{
     /// Returns an error if the connection is disconnected.
     /// If the disconnection in question was normal,
     ///  i.e. the result of a call to [`__sdk::DbContext::disconnect`],
-    /// the returned error will be downcastable to [`__sdk::DisconnectedError`].
+    /// the returned error will be downcastable to [`__sdk::Error::Disconnected`].
     ///
     /// This is a low-level primitive exposed for power users who need significant control over scheduling.
     /// Most applications should call [`Self::frame_tick`] each frame
@@ -1331,7 +1331,7 @@ impl DbConnection {{
     /// Returns an error if the connection is disconnected.
     /// If the disconnection in question was normal,
     ///  i.e. the result of a call to [`__sdk::DbContext::disconnect`],
-    /// the returned error will be downcastable to [`__sdk::DisconnectedError`].
+    /// the returned error will be downcastable to [`__sdk::Error::Disconnected`].
     ///
     /// This is a low-level primitive exposed for power users who need significant control over scheduling.
     /// Most applications should call [`Self::run_threaded`] to spawn a thread
@@ -1345,7 +1345,7 @@ impl DbConnection {{
     /// Returns an error if the connection is disconnected.
     /// If the disconnection in question was normal,
     ///  i.e. the result of a call to [`__sdk::DbContext::disconnect`],
-    /// the returned error will be downcastable to [`__sdk::DisconnectedError`].
+    /// the returned error will be downcastable to [`__sdk::Error::Disconnected`].
     ///
     /// This is a low-level primitive exposed for power users who need significant control over scheduling.
     /// Most applications should call [`Self::run_async`] to run an `async` loop

crates/cli/src/subcommands/subscribe.rs

@@ -198,7 +198,7 @@ where
     ws.send(msg.into()).await
 }
 
-/// Await the initial [`ws::ServerMessage::TransactionUpdateLight`] `|` [`ws::ServerMessage::TransactionUpdate`].
+/// Await the initial [`ws::ServerMessage::SubscriptionUpdate`].
 /// If `module_def` is `Some`, print a JSON representation to stdout.
 async fn await_initial_update<S>(ws: &mut S, module_def: Option<&RawModuleDefV9>) -> anyhow::Result<()>
 where
@@ -232,7 +232,7 @@ where
     Ok(())
 }
 
-/// Print `num` [`ws::ServerMessage::TransactionUpdateLight`] `|` [`ws::ServerMessage::TransactionUpdate`] messages as JSON.
+/// Print `num` [`ws::ServerMessage::TransactionUpdateLight`] or [`ws::ServerMessage::TransactionUpdate`] messages as JSON.
 /// If `num` is `None`, keep going indefinitely.
 async fn consume_transaction_updates<S>(
     ws: &mut S,

crates/cli/tests/snapshots/codegen__codegen_rust.snap

@@ -1803,7 +1803,7 @@ impl DbConnection {
     /// Returns an error if the connection is disconnected.
     /// If the disconnection in question was normal,
     ///  i.e. the result of a call to [`__sdk::DbContext::disconnect`],
-    /// the returned error will be downcastable to [`__sdk::DisconnectedError`].
+    /// the returned error will be downcastable to [`__sdk::Error::Disconnected`].
     ///
     /// This is a low-level primitive exposed for power users who need significant control over scheduling.
     /// Most applications should call [`Self::frame_tick`] each frame
@@ -1817,7 +1817,7 @@ impl DbConnection {
     /// Returns an error if the connection is disconnected.
     /// If the disconnection in question was normal,
     ///  i.e. the result of a call to [`__sdk::DbContext::disconnect`],
-    /// the returned error will be downcastable to [`__sdk::DisconnectedError`].
+    /// the returned error will be downcastable to [`__sdk::Error::Disconnected`].
     ///
     /// This is a low-level primitive exposed for power users who need significant control over scheduling.
     /// Most applications should call [`Self::run_threaded`] to spawn a thread
@@ -1831,7 +1831,7 @@ impl DbConnection {
     /// Returns an error if the connection is disconnected.
     /// If the disconnection in question was normal,
     ///  i.e. the result of a call to [`__sdk::DbContext::disconnect`],
-    /// the returned error will be downcastable to [`__sdk::DisconnectedError`].
+    /// the returned error will be downcastable to [`__sdk::Error::Disconnected`].
     ///
     /// This is a low-level primitive exposed for power users who need significant control over scheduling.
     /// Most applications should call [`Self::run_async`] to run an `async` loop

crates/core/src/host/wasm_common/instrumentation.rs

@@ -14,10 +14,10 @@
 //! `noop` does nothing.
 //! `op` uses `std::time::Instant` and `std::time::Duration` to capture timings.
 //! Components which use the time-span interface will conditionally import one of the two modules, like:
-//! ```no_run
-//! #[cfg(feature = "spacetimedb-wasm-instance-times)]
+//! ```no-run
+//! #[cfg(feature = "spacetimedb-wasm-instance-times")]
 //! use instrumentation::op as span;
-//! #[cfg(not(feature = "spacetimedb-wasm-instance-times)]
+//! #[cfg(not(feature = "spacetimedb-wasm-instance-times"))]
 //! use instrumentation::noop as span;
 //! ```
 

crates/sdk/tests/connect_disconnect_client/src/module_bindings/mod.rs

@@ -98,7 +98,7 @@ pub unsafe trait ReadColumn: Sized {
     /// A few highlights are included here:
     ///
     /// - Variable-length columns, i.e. `AlgebraicType::String`, `AlgebraicType::Array` and `AlgebraicType::Map`
-    ///   are stored within the row as [`crate::var_len::VarLenRef`]'s,
+    ///   are stored within the row as [`crate::var_len::VarLenRef`]s,
     ///   which refer to an intrusive linked list of 62-byte "granules",
     ///   allocated separately in a space starting from the end of the page.
     ///   Strings are stored as UTF-8 bytes; all other var-len types are stored as BSATN-encoded bytes.