-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clog should write to stdout #58
Comments
I'm actually a big fan of this as it follows the unix standard, and upon seeing everything output to the screen, most users will simply
What's TBD though is should |
Is that needed when clogs simply always prepends?
Right, I think |
I agree, if the path given (via |
I agree. I'd propose the following:
This is actually how Unfortunately, we can't check if |
Yes sorry, my bad. Obviously if the user uses |
How do other UNIX command handle that case? |
Maybe we should just assume that the user knows how to use |
That's what I'd recommend 👍 (and hope they don't try |
@kbknapp this can easily be part of the developer guide documentation. |
Well yes, see my previous comment. As @kbknapp says, you can't do anything otherwise because If you want to prepend, best use something like:
Of course, you should just use |
We also shouldn't forget that this would be a breaking change and bumps the version to |
Currently, clog creates a markdown file by default. As discussed in #57, I think it'd make sense if writers could be swapped out.
This raises my next question: Unix commands usually write to stdout by default. If we implement a writer abstraction, so we can plug more into clog, we shouldn't prefer one over the other. Which brings me to the point, that it might be better if
clog
writes to stdout by default.Of course, this adds the complexity that you always have to provide a writer option in case you don't want to write to stdout, but this is how most/all UNIX commands work.
Thoughts on this?
The text was updated successfully, but these errors were encountered: