Mark the clojuredocs lookup request completed on done

`cider-clojuredocs--lookup-async' was the only accumulate-then-done
request handler that didn't call `nrepl--mark-id-completed' (unlike the
analogous handlers in cider-compilation and cider-test), so its handler
lingered in the pending table and a late "done" message would re-fire
the callback.  Mark it completed, matching the others.

Author: bbatsov

lisp/cider-clojuredocs.el

@@ -60,10 +60,11 @@ the symbol has no ClojureDocs entry, or the middleware is unavailable)."
     (cider-nrepl-send-request
      `("op" "cider/clojuredocs-lookup" "ns" ,ns "sym" ,sym)
      (lambda (response)
-       (nrepl-dbind-response response (clojuredocs status)
+       (nrepl-dbind-response response (clojuredocs status id)
          (when clojuredocs
            (setq result clojuredocs))
          (when (member "done" status)
+           (nrepl--mark-id-completed id)
            (funcall callback result)))))))
 
 (defun cider-clojuredocs-replace-special (name)

test/cider-clojuredocs-tests.el

@@ -60,3 +60,16 @@
   (it "leaves unqualified symbols unchanged"
       (expect (cider-clojuredocs--strip-ns "/") :to-equal "/")
       (expect (cider-clojuredocs--strip-ns "subs") :to-equal "subs")))
+
+(describe "cider-clojuredocs--lookup-async"
+  (it "marks the request completed and invokes the callback with the result on done"
+    (let (handler cb-result)
+      (spy-on 'cider-nrepl-send-request :and-call-fake
+              (lambda (_request callback) (setq handler callback)))
+      (spy-on 'nrepl--mark-id-completed)
+      (cider-clojuredocs--lookup-async "clojure.core" "map"
+                                       (lambda (r) (setq cb-result r)))
+      (funcall handler (nrepl-dict "id" "7" "clojuredocs" (nrepl-dict "name" "map")))
+      (funcall handler (nrepl-dict "id" "7" "status" '("done")))
+      (expect 'nrepl--mark-id-completed :to-have-been-called-with "7")
+      (expect cb-result :to-equal (nrepl-dict "name" "map")))))