Skip to content

Commit 392d417

Browse files
authored
Address remaining reflection warnings (#324)
1 parent cd42887 commit 392d417

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

project.clj

+2-3
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@
4646

4747
:lein-plugin {:source-paths ["lein-plugin"]}
4848
:test {:dependencies [[print-foo "1.0.2"]]}
49-
:dev {:global-vars {*warn-on-reflection* true}
50-
:dependencies [[org.clojure/clojurescript "1.10.520"]
49+
:dev {:dependencies [[org.clojure/clojurescript "1.10.520"]
5150
[org.clojure/core.async "1.3.618" :exclusions [org.clojure/clojure org.clojure/tools.reader]]
5251
[cider/piggieback "0.5.2"]
5352
[commons-io/commons-io "2.8.0"]]
@@ -67,7 +66,7 @@
6766
with-debug-bindings [[:inner 0]]
6867
merge-meta [[:inner 0]]
6968
try-if-let [[:block 1]]}}}]
70-
:eastwood {:plugins [[jonase/eastwood "0.7.1"]]
69+
:eastwood {:plugins [[jonase/eastwood "0.9.1"]]
7170
:eastwood {;; vendored - shouldn't be tweaked for satisfying linters:
7271
:exclude-namespaces [refactor-nrepl.ns.slam.hound.regrow]
7372
;; :implicit-dependencies would fail spuriously when the CI matrix runs for Clojure < 1.10,

test/refactor_nrepl/ns/resolve_missing_test.clj

+4-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@
1212

1313
(defn session-fixture
1414
[f]
15-
(with-open [server (server/start-server :bind "localhost" :handler *handler*)
15+
(with-open [^nrepl.server.Server
16+
server (server/start-server :bind "localhost" :handler *handler*)
17+
^nrepl.transport.FnTransport
1618
transport (nrepl/connect :port (:port server))]
1719
(let [client (nrepl/client transport Long/MAX_VALUE)]
1820
(binding [*session* (nrepl/client-session client)]
@@ -77,7 +79,7 @@
7779
(t/is (= 'cljs.repl name))
7880
(t/is (= :ns type)))
7981
(t/testing "Finds macros"
80-
(let [{:keys [error] :as response} (message {:op :resolve-missing :symbol 'dir})
82+
(let [{:keys [^String error] :as response} (message {:op :resolve-missing :symbol 'dir})
8183
{:keys [name type]} (first (edn/read-string (:candidates response)))]
8284
(when error
8385
(throw (RuntimeException. error)))

0 commit comments

Comments
 (0)