Skip to content

Commit a9dabe7

Browse files
authored
Merge pull request #56 from clojureverse/pull-request-template
Problem: the pull request template is out of date
2 parents 54924f2 + d0b6155 commit a9dabe7

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

docs/pull_request_template.md

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
<!--
2-
Please write a short description of what your pull request does, as well as describing anything noteworthy about how you approached things.
2+
This process uses the Collective Code Construction Contract
3+
https://rfc.zeromq.org/spec:44/C4/
34
4-
Thank you for submitting a pull request! Someone will review your code, and if it all looks good, it will get merged.
5+
We merge quickly, but do keep a few things in mind
56
6-
People are granted commit right after they make a valuable contribution, but this does not mean you can push to master or merge your own commits. It does mean you can review other people's commits, and merge them if they look good.
7-
8-
Please give people a few days to respond. If you don't get any response within a few days, try politely asking people directly. Start with people who have worked on the same files/features, or who generally seem active here. If nobody responds, then ping @plexus :)
7+
- make small PRs
8+
- state the problem you are addressing (Problem: ... Solution: ...)
9+
- add yourself to CONTRIBUTORS.md
10+
- try not to break the build
911
-->
10-
11-
- [ ] My code conforms to this project's [Style Guide](https://github.com/clojureverse/clojurians-log-app/blob/master/docs/STYLE.md)
12-
- [ ] I have added tests for functions or features I've added
13-
- [ ] All tests are green (`lein test`)

0 commit comments

Comments
 (0)