Problem: test suite fails since introducing the indexer

Solution:
Extend the test-helpers so that they populate the indexes.

Author: plexus

src/clojurians_log/repl.clj

@@ -205,13 +205,13 @@
      (time (clojurians-log.db.queries/user-names db #{"U2TUBBPNU"}))
      (time (clojurians-log.db.queries/channel-days db "clojurescript"))
 
-     nil)
-
-   "Elapsed time: 18.166254 msecs"
-   "Elapsed time: 631.458841 msecs"
-   "Elapsed time: 1.568807 msecs"
-   "Elapsed time: 16.425878 msecs"
-   "Elapsed time: 1.126005 msecs"
-   "Elapsed time: 1535.355001 msecs"
-   "Elapsed time: 2205.20762 msecs"
-   ))
+     nil))
+
+  "Elapsed time: 18.166254 msecs"
+  "Elapsed time: 631.458841 msecs"
+  "Elapsed time: 1.568807 msecs"
+  "Elapsed time: 16.425878 msecs"
+  "Elapsed time: 1.126005 msecs"
+  "Elapsed time: 1535.355001 msecs"
+  "Elapsed time: 2205.20762 msecs"
+  )

test/clojurians_log/db/queries_test.clj

@@ -9,15 +9,15 @@
 (deftest channel-list-test
   (testing "without arg - return all channels"
     (let [[conn db] (test-db)]
-      (is (= (channel-list db)
-             [#:channel{:slack-id "C03S1KBA2", :name "clojure"}
-              #:channel{:slack-id "C03S1L9DN", :name "clojurescript"}]))))
+      (is (= [#:channel{:slack-id "C03S1KBA2", :name "clojure"}
+              #:channel{:slack-id "C03S1L9DN", :name "clojurescript"}]
+             (channel-list db)))))
 
   (testing "returns only channels with messages on the given day, includes message-count"
     (let [[conn db] (test-db "quiet-channels")]
-      (is (= (channel-list db "2018-02-03")
-             [#:channel{:slack-id "C7YF1SBT3", :name "reitit", :message-count 3}
-              #:channel{:slack-id "C05006WDW", :name "jobs", :message-count 1}])))))
+      (is (= [#:channel{:slack-id "C05006WDW", :name "jobs", :message-count 1}
+              #:channel{:slack-id "C7YF1SBT3", :name "reitit", :message-count 3}]
+             (channel-list db "2018-02-03"))))))
 
 (deftest threaded-messages-test
   (let [[conn db] (test-db "threaded-messages")
@@ -50,15 +50,15 @@
     ;; The following tests should hold given the contents of threaded-messages.edn
     ;; To see how the data was generated, see repl/test_data.clj.
     (testing "returns messages for the expected threads"
-      (is (= parents-ts
-             #{"1517995093.000487" "1518040988.000079"}))
+      (is (= #{"1517995093.000487" "1518040988.000079"}
+             parents-ts))
 
       ;; Does not contain message for threads not starting on the target date
       (is (not (contains? parents-ts "1517924158.000577"))))
 
     (testing "returns the expected messages"
-      (is (= thread-messages-ts
-             #{"1518008583.000370" "1518058291.000073" "1518095027.000404" "1518095379.000012"}))
+      (is (= #{"1518008583.000370" "1518058291.000073" "1518095027.000404" "1518095379.000012"}
+             thread-messages-ts))
 
       ;; Should exclude non-threaded message from the same day
       (is (not (contains? thread-messages-ts "1518034517.000637")))

test/clojurians_log/test_helper.clj

@@ -1,6 +1,7 @@
 (ns clojurians-log.test-helper
   (:require [clojure.java.io :as io]
             [clojurians-log.db.schema :as schema]
+            [clojurians-log.db.queries :as queries]
             [clojurians-log.xml2hiccup :as x2h]
             [datomic.api :as d]
             [net.cgrand.enlive-html :as enlive]
@@ -35,7 +36,9 @@
   ([fixture-name]
    (let [conn (test-conn)]
      (transact-txs conn (slurp-fixture fixture-name))
-     [conn (d/db conn)])))
+     (let [db (d/db conn)]
+       (queries/build-indexes! db)
+       [conn (d/db conn)]))))
 
 (defn html->hiccup [html]
   (-> html
@@ -64,8 +67,10 @@
       (assoc-in [:datomic :uri] (str "datomic:mem:" (gensym "test_db")))
       (dissoc :http)               ;; don't actually start a http server
       (dissoc :server-info)        ;; silence http server startup message
-      component/start-system))     ;; start the whole system
+      component/start-system))
 
 (defn system-load-fixture! [system fixture-name]
   (transact-txs (system-db-conn system)
-                (slurp-fixture fixture-name)))
+                (slurp-fixture fixture-name))
+  (queries/build-indexes! (system-db system))
+  nil)

test/clojurians_log/views_test.clj

@@ -9,8 +9,8 @@
 
 (deftest page-head-test
   (testing "It renders the page title"
-    (is (= (html-select-1 (page-head {:data/title "Hello, world"}) [:head :title])
-           [:title "Hello, world"]))))
+    (is (= [:title "Hello, world"]
+           (html-select-1 (page-head {:data/title "Hello, world"}) [:head :title])))))
 
 (deftest routes-test
   (testing "All known routes should return http ok (200)"
@@ -37,7 +37,7 @@
       ;; TODO Some urls responds quite slowly (around 500ms)
       (doseq [url urls
               :let [response (ring-handler (mock/request :get url))]]
-        (is (= (:status response) 200) url)))))
+        (is (= 200 (:status response)) url)))))
 
 (deftest log-page-test
   (let [log-page (-> {:data/date "2018-01-02"
@@ -49,10 +49,10 @@
                      :response/html)]
 
     (testing "It links to the front page and to prev/next days"
-      (is (= (html-select log-page [:a])
-             [[:a {:href "/"} "Clojurians"]
+      (is (= [[:a {:href "/"} "Clojurians"]
               [:a {:href "/clojure/2018-01-01"} [:div.day-prev "<"]]
-              [:a {:href "/clojure/2018-01-03"} [:div.day-next ">"]]]))))
+              [:a {:href "/clojure/2018-01-03"} [:div.day-next ">"]]]
+             (html-select log-page [:a])))))
 
   (let [system (h/test-system)