fix(examples): Standalone example works now

Author: baolsen

.github/workflows/pr-title.yml

@@ -29,15 +29,15 @@ jobs:
           # Configure that a scope must always be provided.
           requireScope: false
           # Configure additional validation for the subject based on a regex.
-          # This example ensures the subject starts with an uppercase character.
-          subjectPattern: ^[A-Z].+$
+          # This example ensures the subject starts with a character.
+          subjectPattern: ^[A-Za-z].+$
           # If `subjectPattern` is configured, you can use this property to override
           # the default error message that is shown when the pattern doesn't match.
           # The variables `subject` and `title` can be used within the message.
           subjectPatternError: |
             The subject "{subject}" found in the pull request title "{title}"
             didn't match the configured pattern. Please ensure that the subject
-            starts with an uppercase character.
+            starts with a character.
           # For work-in-progress PRs you can typically use draft pull requests
           # from Github. However, private repositories on the free plan don't have
           # this option and therefore this action allows you to opt-in to using the

examples/standalone/README.md

@@ -38,21 +38,60 @@ resource "random_pet" "run_id" {
   }
 }
 
-resource "aws_cloudwatch_log_group" "this" {
-  name              = local.naming_prefix
-  retention_in_days = 1
+#---------------------------------------
+# Cloudtrail infrastructure - standalone
+#---------------------------------------
+# S3 bucket
+module "logs_bucket" {
+  source  = "trussworks/logs/aws"
+  version = "~> 14"
+
+  s3_bucket_name = local.naming_prefix
+
+  allow_cloudtrail = true
+  force_destroy    = true
 }
 
+# Cloudtrail
+locals {
+  naming_prefix_cloudtrail = "${local.naming_prefix}-cloudtrail"
+}
+module "aws_cloudtrail" {
+  source  = "trussworks/cloudtrail/aws"
+  version = "~> 4"
+
+  s3_bucket_name = module.logs_bucket.aws_logs_bucket
+
+  trail_name      = local.naming_prefix_cloudtrail
+  iam_policy_name = local.naming_prefix_cloudtrail
+  iam_role_name   = local.naming_prefix_cloudtrail
+
+  cloudwatch_log_group_name = local.naming_prefix_cloudtrail
+  log_retention_days        = 30
+}
+
+#---------------------------------------
+# ClickOps module
+#---------------------------------------
 module "clickops_notifications" {
-  source = "../../"
-
-  standalone           = true
-  naming_prefix        = local.naming_prefix
-  cloudtrail_log_group = aws_cloudwatch_log_group.this.name
-  webhook              = "https://fake.com"
-  message_format       = "slack"
-  tags                 = local.tags
-  lambda_runtime       = "python3.8"
+  source = "../.."
+
+  standalone = true
+
+  naming_prefix = local.naming_prefix
+
+  webhook        = "https://fake.com"
+  message_format = "slack"
+
+  tags = local.tags
+
+  # cloudtrail_bucket_name = aws_s3_bucket.clickops_cloudtrail.id
+  cloudtrail_log_group = local.naming_prefix_cloudtrail
+
+  depends_on = [
+    module.aws_cloudtrail
+  ]
+
 }
 ```
 ----
@@ -71,7 +110,9 @@ module "clickops_notifications" {
 
 | Name | Source | Version |
 |------|--------|---------|
-| <a name="module_clickops_notifications"></a> [clickops\_notifications](#module\_clickops\_notifications) | ../../ | n/a |
+| <a name="module_aws_cloudtrail"></a> [aws\_cloudtrail](#module\_aws\_cloudtrail) | trussworks/cloudtrail/aws | ~> 4 |
+| <a name="module_clickops_notifications"></a> [clickops\_notifications](#module\_clickops\_notifications) | ../.. | n/a |
+| <a name="module_logs_bucket"></a> [logs\_bucket](#module\_logs\_bucket) | trussworks/logs/aws | ~> 14 |
 
 ----
 ### Outputs
@@ -83,7 +124,6 @@ No outputs.
 
 | Name | Version |
 |------|---------|
-| <a name="provider_aws"></a> [aws](#provider\_aws) | 4.9.0 |
 | <a name="provider_random"></a> [random](#provider\_random) | 3.4.3 |
 
 ----
@@ -100,7 +140,6 @@ No outputs.
 
 | Name | Type |
 |------|------|
-| [aws_cloudwatch_log_group.this](https://registry.terraform.io/providers/hashicorp/aws/4.9.0/docs/resources/cloudwatch_log_group) | resource |
 | [random_pet.run_id](https://registry.terraform.io/providers/hashicorp/random/3.4.3/docs/resources/pet) | resource |
 
 ----

examples/standalone/main.tf

@@ -34,19 +34,58 @@ resource "random_pet" "run_id" {
   }
 }
 
-resource "aws_cloudwatch_log_group" "this" {
-  name              = local.naming_prefix
-  retention_in_days = 1
+#---------------------------------------
+# Cloudtrail infrastructure - standalone
+#---------------------------------------
+# S3 bucket
+module "logs_bucket" {
+  source  = "trussworks/logs/aws"
+  version = "~> 14"
+
+  s3_bucket_name = local.naming_prefix
+
+  allow_cloudtrail = true
+  force_destroy    = true
+}
+
+# Cloudtrail
+locals {
+  naming_prefix_cloudtrail = "${local.naming_prefix}-cloudtrail"
+}
+module "aws_cloudtrail" {
+  source  = "trussworks/cloudtrail/aws"
+  version = "~> 4"
+
+  s3_bucket_name = module.logs_bucket.aws_logs_bucket
+
+  trail_name      = local.naming_prefix_cloudtrail
+  iam_policy_name = local.naming_prefix_cloudtrail
+  iam_role_name   = local.naming_prefix_cloudtrail
+
+  cloudwatch_log_group_name = local.naming_prefix_cloudtrail
+  log_retention_days        = 30
 }
 
+#---------------------------------------
+# ClickOps module
+#---------------------------------------
 module "clickops_notifications" {
-  source = "../../"
-
-  standalone           = true
-  naming_prefix        = local.naming_prefix
-  cloudtrail_log_group = aws_cloudwatch_log_group.this.name
-  webhook              = "https://fake.com"
-  message_format       = "slack"
-  tags                 = local.tags
-  lambda_runtime       = "python3.8"
+  source = "../.."
+
+  standalone = true
+
+  naming_prefix = local.naming_prefix
+
+  webhook        = "https://fake.com"
+  message_format = "slack"
+
+  tags = local.tags
+
+  # cloudtrail_bucket_name = aws_s3_bucket.clickops_cloudtrail.id
+  cloudtrail_log_group = local.naming_prefix_cloudtrail
+
+  depends_on = [
+    module.aws_cloudtrail
+  ]
+
 }