-
Notifications
You must be signed in to change notification settings - Fork 995
Open
Labels
Priority: NormalMinor issue impacting one or more usersMinor issue impacting one or more usersType: BugSomething isn't workingSomething isn't working
Description
Describe the bug
RISC-V compilation is not supported, even though a minor change can unblock it. So, I'd make it a bug report, rather than a feature request.
To Reproduce
Steps to reproduce the behavior:
- Download the official Golang toolchain for RISC-V
- Set
GOROOT_BOOTSTRAP
to this go toolchain, e.g.,$HOME/go
- Manually execute the commands in https://github.com/cloudflare/cloudflared/blob/master/.teamcity/install-cloudflare-go.sh
- Clone this repo
- Set
GOPATH
to the compiled cloudflare-flavored go, e.g.,/tmp/go
- Run
make cloudflared
- Then we get an error
This system's architecture riscv64 isn't supported
from hereLine 78 in 1f3e304
$(error This system's architecture $(LOCAL_ARCH) isn't supported)
Expected behavior
Compiling from source for RISC-V machines is supported.
Environment and versions
- OS: Linux Debian
- Architecture: riscv64
- Version: master at 1f3e304
Simple Fix
I just appended two lines
else ifeq ($(LOCAL_ARCH),riscv64)
TARGET_ARCH ?= riscv64
Then everything went smoothly and the compiled cloudflared
worked great.
If you are willing to accept a PR, I can make one in no time.
shalupov, samtka, zpatronus, SourLemonJuice and Den4200
Metadata
Metadata
Assignees
Labels
Priority: NormalMinor issue impacting one or more usersMinor issue impacting one or more usersType: BugSomething isn't workingSomething isn't working