Fix linting errors

Signed-off-by: Aram Price <aram.price@broadcom.com>
Co-authored-by: Aram Price <aram.price@broadcom.com>

Author: mariash

handler/common_event_format.go

@@ -52,7 +52,7 @@ func (cef concreteCommonEventFormat) ProduceHTTPRequestEventLog(request *http.Re
 		var buffer bytes.Buffer
 
 		buffer.WriteString(extension)
-		buffer.WriteString(fmt.Sprintf("cs4=%s cs4Label=statusReason", respBody))
+		buffer.WriteString(fmt.Sprintf("cs4=%s cs4Label=statusReason", respBody)) //nolint:staticcheck
 		extension = buffer.String()
 	}
 
@@ -73,7 +73,7 @@ func (cef concreteCommonEventFormat) ProduceNATSRequestEventLog(addr string, por
 		var buffer bytes.Buffer
 
 		buffer.WriteString(extension)
-		buffer.WriteString(fmt.Sprintf("cs1=%s cs1Label=statusReason", respBody))
+		buffer.WriteString(fmt.Sprintf("cs1=%s cs1Label=statusReason", respBody)) //nolint:staticcheck
 		extension = buffer.String()
 	}
 

monitaccess/monit_access_linux.go

@@ -27,7 +27,7 @@ func EnableMonitAccess(logger boshlog.Logger, command string, args []string) {
 		if err != nil {
 			os.Exit(1)
 		}
-		defer mgr.Cleanup()
+		defer mgr.Cleanup() //nolint:errcheck
 		os.Exit(0)
 	}
 
@@ -40,7 +40,7 @@ func EnableMonitAccess(logger boshlog.Logger, command string, args []string) {
 		logger.Error(command, "Failed to create firewall manager: %v", err)
 		os.Exit(1)
 	}
-	defer mgr.Cleanup()
+	defer mgr.Cleanup() //nolint:errcheck
 
 	// Setup mode: add firewall rule
 	logger.Info(command, "Setting up monit firewall rule")

monitaccess/monit_access_windows.go

@@ -3,9 +3,11 @@ package monitaccess
 import (
 	"fmt"
 	"os"
+
+	boshlog "github.com/cloudfoundry/bosh-utils/logger"
 )
 
-func EnableMonitAccess(command string, args []string) {
+func EnableMonitAccess(logger boshlog.Logger, command string, args []string) {
 	fmt.Fprintf(os.Stderr, "enable-monit-access: not implemented for windows")
 	os.Exit(1)
 }

platform/firewall/nftables_firewall_test.go

@@ -277,10 +277,6 @@ var _ = Describe("NftablesFirewall", func() {
 				err := manager.EnableMonitAccess()
 				Expect(err).To(HaveOccurred())
 				Expect(err.Error()).To(ContainSubstring("bosh_agent table not found"))
-			})
-
-			It("does not add any rules", func() {
-				_ = manager.EnableMonitAccess()
 				Expect(fakeConn.AddRuleCallCount()).To(Equal(0))
 			})
 		})