Skip to content

Commit dad679a

Browse files
committed
bug: return early on error
no point in trying to read a file we couldn't open
1 parent cde015a commit dad679a

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

src/pxc-replicator/client/client.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,8 +234,10 @@ func (r *ReplClient) ListBackups() ([]string, error) {
234234
func (r *ReplClient) GetGTIDFromBackupFile(fileName string) (string, bool) {
235235
dump, err := os.Open(fileName)
236236
if err != nil {
237-
log.Printf("skipping %s, could not open: %s", fileName, err.Error())
237+
log.Printf("failed open to open `%s` for GTID search: %s", fileName, err.Error())
238+
return "", false
238239
}
240+
defer dump.Close()
239241
fileReader := bufio.NewReader(dump)
240242
for {
241243
line, err := fileReader.ReadString('\n')
@@ -608,7 +610,6 @@ func registerTLSConfig(name string, certs config.Certs) error {
608610
RootCAs: rootCertPool,
609611
Certificates: []tls.Certificate{},
610612
})
611-
612613
//tlsCerts, err := tls.X509KeyPair(certs.Certificate, certs.PrivateKey)
613614
//if err != nil {
614615
// return fmt.Errorf("failed parsing certs: %w", err)

0 commit comments

Comments
 (0)