Skip to content

Commit 012f3b6

Browse files
authored
chore: fix LZ4 builds on arm64 (#162)
build-essential and python3-dev are required to build LZ4 on arm64 since there aren't pre-compiled wheel available for this architecture. Also, switch back to using the latest qemu image. Signed-off-by: Niccolò Fei <[email protected]>
1 parent f60749a commit 012f3b6

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

.github/workflows/bake.yaml

-2
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ jobs:
4848
uses: docker/setup-qemu-action@v3
4949
with:
5050
platforms: 'arm64'
51-
# TODO: remove once https://github.com/docker/setup-qemu-action/issues/198 is fixed
52-
image: 'tonistiigi/binfmt:qemu-v7.0.0'
5351

5452
- name: Set up Docker Buildx
5553
uses: docker/setup-buildx-action@v3

.github/workflows/build.yml

-2
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ jobs:
4545
uses: docker/setup-qemu-action@v3
4646
with:
4747
platforms: ${{ matrix.platforms }}
48-
# TODO: remove once https://github.com/docker/setup-qemu-action/issues/198 is fixed
49-
image: 'tonistiigi/binfmt:qemu-v7.0.0'
5048

5149
- name: Docker meta
5250
env:

Debian/Dockerfile-beta.template

+3
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,16 @@ RUN set -xe; \
4141
RUN set -xe; \
4242
apt-get update; \
4343
apt-get install -y --no-install-recommends \
44+
# We require build-essential and python3-dev to build lz4 on arm64 since there isn't a pre-compiled wheel available
45+
build-essential python3-dev \
4446
python3-pip \
4547
python3-psycopg2 \
4648
python3-setuptools \
4749
; \
4850
pip3 install %%PIP_OPTIONS%% --upgrade pip; \
4951
# TODO: Remove --no-deps once https://github.com/pypa/pip/issues/9644 is solved
5052
pip3 install %%PIP_OPTIONS%% --no-deps -r requirements.txt; \
53+
apt-get remove -y --purge --autoremove build-essential python3-dev; \
5154
rm -rf /var/lib/apt/lists/*;
5255

5356
# Change the uid of postgres to 26

Debian/Dockerfile.template

+3
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,16 @@ RUN set -xe; \
4343
RUN set -xe; \
4444
apt-get update; \
4545
apt-get install -y --no-install-recommends \
46+
# We require build-essential and python3-dev to build lz4 on arm64 since there isn't a pre-compiled wheel available
47+
build-essential python3-dev \
4648
python3-pip \
4749
python3-psycopg2 \
4850
python3-setuptools \
4951
; \
5052
pip3 install %%PIP_OPTIONS%% --upgrade pip; \
5153
# TODO: Remove --no-deps once https://github.com/pypa/pip/issues/9644 is solved
5254
pip3 install %%PIP_OPTIONS%% --no-deps -r requirements.txt; \
55+
apt-get remove -y --purge --autoremove build-essential python3-dev; \
5356
rm -rf /var/lib/apt/lists/*;
5457

5558
# Change the uid of postgres to 26

0 commit comments

Comments
 (0)