fix(types): fix misleading comments and ownerOpeation typo in OwnerChangeCalculator

- Update dedup loop comments to accurately describe that any existing
  operation (pending, complete, failed, etc.) suppresses re-queuing,
  not just waiting or completed ones.
- Rename loop variable ownerOpeation → ownerOperation in both add and
  remove loops for readability.
- Fix pendingAdminMembers doc comment: these are users with pending
  invitations, not org members.

Signed-off-by: Onur Yilmaz <onur.yilmaz@sap.com>

Author: onuryilmaz

api/v1/githuborganization_types.go

@@ -226,11 +226,11 @@ func (g GithubOrganization) OwnerChangeCalculator(ownersFromKubernetes []Member)
 		if !githubOwnerFound {
 			// action: add the owner to github
 
-			// check if there is a waiting or already-completed task
-			// A completed add operation means the user was already successfully added; do not re-queue.
+			// check if there is any existing task (pending, complete, failed, etc.)
+			// Any existing add operation suppresses re-queuing, regardless of state.
 			ownerOperationFound := false
-			for _, ownerOpeation := range newStatus.Operations.OrganizationOwnerOperations {
-				if strings.EqualFold(ownerOpeation.User, kubernetesOwner.GithubUsername) && ownerOpeation.Operation == GithubUserOperationTypeAdd {
+			for _, ownerOperation := range newStatus.Operations.OrganizationOwnerOperations {
+				if strings.EqualFold(ownerOperation.User, kubernetesOwner.GithubUsername) && ownerOperation.Operation == GithubUserOperationTypeAdd {
 					ownerOperationFound = true
 					break
 				}
@@ -265,11 +265,11 @@ func (g GithubOrganization) OwnerChangeCalculator(ownersFromKubernetes []Member)
 		if !kubernetesOwnerFound {
 			// action: remove the owner from github
 
-			// check if there is a waiting or already-completed task
-			// A completed remove operation means the user was already successfully removed; do not re-queue.
+			// check if there is any existing task (pending, complete, failed, etc.)
+			// Any existing remove operation suppresses re-queuing, regardless of state.
 			ownerOperationFound := false
-			for _, ownerOpeation := range newStatus.Operations.OrganizationOwnerOperations {
-				if strings.EqualFold(ownerOpeation.User, githubOwner.GithubUsername) && ownerOpeation.Operation == GithubUserOperationTypeRemove {
+			for _, ownerOperation := range newStatus.Operations.OrganizationOwnerOperations {
+				if strings.EqualFold(ownerOperation.User, githubOwner.GithubUsername) && ownerOperation.Operation == GithubUserOperationTypeRemove {
 					ownerOperationFound = true
 					break
 				}

internal/github/organizations.go

@@ -122,7 +122,7 @@ func (o *DefaultOrganizationProvider) OwnersExtended(ctx context.Context) ([]Git
 	return append(active, pending...), nil
 }
 
-// pendingAdminMembers returns org members who have a pending invitation with the admin role.
+// pendingAdminMembers returns users with pending admin invitations to the org.
 // ListMembers only returns active members, so without this, users whose invite is still pending
 // are invisible to OwnersExtended and get re-invited on every reconcile.
 func (o *DefaultOrganizationProvider) pendingAdminMembers(ctx context.Context) ([]GithubMember, error) {