Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor issue when using SSH-formatted Git URLs #1049

Closed
MrZablah opened this issue Feb 11, 2025 · 2 comments · Fixed by #1054 · May be fixed by #1061
Closed

Vendor issue when using SSH-formatted Git URLs #1049

MrZablah opened this issue Feb 11, 2025 · 2 comments · Fixed by #1054 · May be fixed by #1061
Labels
bug 🐛 An issue with the system

Comments

@MrZablah
Copy link

MrZablah commented Feb 11, 2025

Describe the Bug

When using a Go-getter ssh git type url Atmos gives this error:
ERRO parse "[email protected]:cloudposse/terraform-aws-tfstate-backend.git?ref=v1.5.0": first path segment in URL cannot contain colon

Expected Behavior

It should work and it used to work on older Atmos versions

Steps to Reproduce

Use the latest Atmos version: 1.160.4

Use git ssh on the vendor.yaml file this:

    - component: "terraform-null-label"
      source: "git::[email protected]:cloudposse/terraform-null-label.git?ref={{.Version}}"
      version: "0.25.0"
      targets:
        - "components/terraform/vendor/cloudposse/terraform-null-label"
      included_paths:
        - "**/*.tf"
        - "**/modules/**"
      excluded_paths:
        - "**/providers.tf"
      tags:
        - labels

then just do a normal atmos vendor pull cli cmd and this will give you and error.

Screenshots

Image

Environment

Version: 1.160.4

Additional Context

No response

@MrZablah MrZablah added the bug 🐛 An issue with the system label Feb 11, 2025
@osterman
Copy link
Member

I think this relates to:

The issue with with net/url not handling all go-getter URI formats.

@osterman osterman changed the title Vendor issue when using git ssh Urls Vendor issue when using SSH-formatted Git URLs Feb 12, 2025
@Listener430
Copy link
Collaborator

@MrZablah thanks, #1061 should fix the issue once reviewed/approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
3 participants