Skip to content

Conversation

@meguminnnnnnnnn
Copy link
Contributor

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Need to create a new tag

The following modules have changes and may need version updates:

  • components/model/gemini (Current: components/model/gemini/v0.1.15)

⚠️ Please create and push new version tags for these modules after merging this PR.

@meguminnnnnnnnn meguminnnnnnnnn force-pushed the feat/wdz/agentic_gemini branch 2 times, most recently from bfa9c9a to a36e126 Compare December 3, 2025 07:50
@meguminnnnnnnnn meguminnnnnnnnn changed the base branch from main to release/agentic_model December 3, 2025 07:51
@meguminnnnnnnnn meguminnnnnnnnn force-pushed the feat/wdz/agentic_gemini branch 8 times, most recently from 4cffedc to 938b4d7 Compare December 3, 2025 13:49
@mrh997 mrh997 force-pushed the release/agentic_model branch from 30377f9 to 388b5a2 Compare January 5, 2026 14:42
@mrh997 mrh997 force-pushed the release/agentic_model branch from 388b5a2 to 4f236f1 Compare January 6, 2026 14:13
@meguminnnnnnnnn meguminnnnnnnnn force-pushed the feat/wdz/agentic_gemini branch 9 times, most recently from 01801dc to f019df0 Compare January 8, 2026 02:47
@meguminnnnnnnnn meguminnnnnnnnn force-pushed the feat/wdz/agentic_gemini branch from f019df0 to 1e36ea1 Compare January 8, 2026 03:04
@mrh997 mrh997 force-pushed the release/agentic_model branch from 4f236f1 to 58cc5bf Compare January 14, 2026 15:01
// EnableCodeExecution allows the model to execute code
// Warning: Be cautious with code execution in production
// Optional. Default: false
EnableCodeExecution *genai.ToolCodeExecution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些都是 tool 配置吧,是不是和 Gemini API 设计一样,设计成数组好一些
Image

"google.golang.org/genai"
)

type options struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

内置工具漏了定义 option

if block.ServerToolCall != nil {
switch block.ServerToolCall.Name {
case ServerToolNameCodeExecution:
result, ok := block.ServerToolCall.Arguments.(*ExecutableCode)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前讨论应该是设计成 oneof 类型?不然太多类型断言用户找不到对应的类型了

msg.Extra[groundingMetadataKey] = gm
}

func GetGroundingMetadata(msg *schema.AgenticMessage) *genai.GroundingMetadata {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在 eino ResponseMeta 定义有 gemini 的 metadata

// genInputAndConf generates input messages and configuration for Gemini API
func (g *Gemini) genInputAndConf(input []*schema.AgenticMessage, opts ...agentic.Option) (string, []*schema.AgenticMessage, *genai.GenerateContentConfig, *agentic.Config, error) {
commonOptions := agentic.GetCommonOptions(&agentic.Options{
Temperature: g.temperature,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxTokens 也加到 common option 里了,也补下吧

@mrh997
Copy link
Contributor

mrh997 commented Jan 20, 2026

README 要补一下,另外 pkg 挪到 model 下,叫 agenticgemini ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants