diff --git a/src/Squirrel/Internal/HelperExe.cs b/src/Squirrel/Internal/HelperExe.cs index 9fcebbf92..9225e09e9 100644 --- a/src/Squirrel/Internal/HelperExe.cs +++ b/src/Squirrel/Internal/HelperExe.cs @@ -97,7 +97,7 @@ public static async Task CompileWixTemplateToMsi(string wxsTarget, string output if (processResult.Item1 != 0) { var msg = String.Format( "Failed to compile WiX template, command invoked was: '{0} {1}'\n\nOutput was:\n{2}", - "candle.exe", candleParams, processResult.Item2); + "candle.exe", Utility.ArgsToCommandLine(candleParams), processResult.Item2); throw new Exception(msg); } @@ -109,7 +109,7 @@ public static async Task CompileWixTemplateToMsi(string wxsTarget, string output if (processResult.Item1 != 0) { var msg = String.Format( "Failed to link WiX template, command invoked was: '{0} {1}'\n\nOutput was:\n{2}", - "light.exe", lightParams, processResult.Item2); + "light.exe", Utility.ArgsToCommandLine(lightParams), processResult.Item2); throw new Exception(msg); } diff --git a/src/SquirrelCli/Program.cs b/src/SquirrelCli/Program.cs index 234b9182d..8d14eeda7 100644 --- a/src/SquirrelCli/Program.cs +++ b/src/SquirrelCli/Program.cs @@ -367,7 +367,7 @@ static void Releasify(ReleasifyOptions options) if (!String.IsNullOrEmpty(options.msi)) { bool x64 = options.msi.Equals("x64"); - var msiPath = createMsiPackage(targetSetupExe, new ZipPackage(package), x64).Result; + var msiPath = createMsiPackage(targetSetupExe, bundledzp, x64).Result; options.SignPEFile(msiPath); } @@ -387,7 +387,7 @@ static async Task createMsiPackage(string setupExe, IPackage package, bo { "Id", package.Id }, { "Title", package.ProductName }, { "Author", package.ProductCompany }, - { "Version", Regex.Replace(package.Version.ToString(), @"-.*$", "") }, + { "Version", package.Version.Version.ToString() }, { "Summary", package.ProductDescription }, { "Codepage", $"{culture}" }, { "Platform", packageAs64Bit ? "x64" : "x86" }, diff --git a/vendor/wix/template.wxs b/vendor/wix/template.wxs index c6991f68e..0a7440b17 100644 --- a/vendor/wix/template.wxs +++ b/vendor/wix/template.wxs @@ -1,5 +1,5 @@ - +