events() show wrong range start

[manu37]

If I put events(1,2018,12,0); it shows range from nov 2017 to dec 2018. To get it right I have to set events(03,2018,10,0); to get range jan 2018 to dec 2018.

[cmb69]

One issue here is the $past_month == '' check; if you pass 0 as $past_month (which both plugin calls do), the configured default will be used. If the check used the identity operator (===), this issue wouldn't occur. In my opionion it would even be cleaner, if the parameters would default to null, and the function's code would be adapted respectively.

[manu37]

ok, there ist a config2.php where $past_month etc. can be modified and therefore do whithout the additional parameters. Its beyound my imagination where config2 can be edited whithin CMSimple_XH.

[cmb69]

I believe config2.php is supposed to contain hidden configuration options, i.e. those that cannot be edited from the plugin administration. If I'm right it should be possible to move options from config2.php to config.php (and vice versa). (It might be sensible to merge both files and to mark the options in metaconfig.php as hidden, or maybe advanced. For my liking, there are already too many config options, though.)