-
here 1 and 4 are present in LRU-K replacer, both are marked as evictable and are accessed more than k times(k=2 in this example). As per LRU K logic 1 should be evicted instead of 4 since its backward k-distance is the greater then 4.
-
As per SetEvictable documentation here if frame id is invalid it should throw an exception. Whereas in the test here it does handle the scenario which leads to failure of the tests. We should assert if this is raising an exception.
I have fixes ready in my local. I just want to make if these are valid issues and doesn't violate any policy before raising a PR.
here
1and4are present in LRU-K replacer, both are marked as evictable and are accessed more thanktimes(k=2 in this example). As per LRU K logic1should be evicted instead of4since its backward k-distance is the greater then4.As per
SetEvictabledocumentation here if frame id is invalid it should throw an exception. Whereas in the test here it does handle the scenario which leads to failure of the tests. We should assert if this is raising an exception.I have fixes ready in my local. I just want to make if these are valid issues and doesn't violate any policy before raising a PR.