/indicator_geo_coverage endpoint #1658
Open
+44
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melange396
previously approved these changes
Jul 18, 2025
Comment on lines
+579
to
+580
| def transform_row(row, proxy): | ||
| return f"{row['geo_type']}:{row['geo_value']}" |
There was a problem hiding this comment.
this is awesome! do we wanna change the /geo_indicator endpoint to do something similar?
Comment on lines
+564
to
+565
| @bp.route("/indicator_geo_coverage", methods=("GET", "POST")) | ||
| def handle_indicator_geo_coverage(): |
There was a problem hiding this comment.
im not sure how much this actually matters, but do we wanna change the endpoint name to be more similar to the structure of /geo_coverage?
Suggested change
| @bp.route("/indicator_geo_coverage", methods=("GET", "POST")) | |
| def handle_indicator_geo_coverage(): | |
| @bp.route("/indicator_coverage", methods=("GET", "POST")) | |
| def handle_indicator_coverage(): |
or instead, maybe even rename the other endpoint to "/geo_indicator_coverage"?
Co-authored-by: george <[email protected]>
|
melange396
approved these changes
Jul 18, 2025
|
i think the failing ci should be fixed with #1660 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added new /indicator_geo_coverage endpoint.
It accepts source:signals and returns list of available geo_type:geo_value pairs.
This endpoint is needed for the EpiPortal to show the only list of available geos for the selected indicators.
Prerequisites:
devbranchdev