Skip to content

Refactor layer_naomit() #107

Open
Open
@dajmcdon

Description

@dajmcdon

Refactors layer_naomit() to make sure that it returns NAs for the targets but gets rid of the rest. As I think about it, we actually shouldn't be dropping NAs in the predictions per se, but rather only returning the rows that have meaningful predictions (even if these are NA).

So far, it's been coincidental that the rows with NA are not meaningful. But this isn't foolproof. It may be that NAs are meaningful (as in #106) but it's also possible that they aren't (often as a result of lagging the predictors).

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1high priority

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions