Skip to content

Commit 5d6f0c7

Browse files
committed
fix: improve layer_yj comment with questions and possibilities
1 parent 61d4e96 commit 5d6f0c7

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

R/new_epipredict_steps/layer_yeo_johnson.R

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,16 @@ slather.layer_epi_YeoJohnson <- function(object, components, workflow, new_data,
117117
)
118118

119119
# TODO: There are many possibilities here:
120-
# - (a) the terms can be empty, where we should probably default to all_outcomes()
121-
# - (b) explicitly giving all_outcomes(), we end here with terms being empty
122-
# - (c) if the user just specifies .pred, then we have to infer the outcome from the mold
123-
# - (d) the user might specify outcomes of the form .pred_ahead_1_cases, .pred_ahead_7_cases, etc.
120+
# - (a) the terms can be empty, where we should probably default to
121+
# all_outcomes().
122+
# - (b) explicitly giving all_outcomes(), we end here with terms being empty,
123+
# which doesn't seem right; need to make sure we pull in all the outcome
124+
# columns here. The question is what form should they have?
125+
# - (c) if the user just specifies .pred, then we have to infer the outcome
126+
# from the mold, which is simple enough and the main case I have working.
127+
# - (d) the user might specify outcomes of the form .pred_ahead_1_cases,
128+
# .pred_ahead_7_cases, etc. Is that the right format? Trying those out now
129+
# and getting errors downstream from forecast().
124130
# Get the columns to transform.
125131
exprs <- rlang::expr(c(!!!object$terms))
126132
pos <- tidyselect::eval_select(exprs, components$predictions)

0 commit comments

Comments
 (0)