sql: investigate occasional failures in TestReacquireLeaseOnRestart with test tenants #156333
Description
I've seen this test fail with external-process mode in CI.
In order to reproduce, cherry-pick #156504 (if it hasn't yet merged) and apply this patch
diff --git a/pkg/sql/txn_restart_test.go b/pkg/sql/txn_restart_test.go
index 61f3f5edee0..bad6051e672 100644
--- a/pkg/sql/txn_restart_test.go
+++ b/pkg/sql/txn_restart_test.go
@@ -1297,7 +1297,7 @@ func TestReacquireLeaseOnRestart(t *testing.T) {
params, _ := createTestServerParamsAllowTenants()
params.Knobs.Store = storeTestingKnobs
params.Knobs.KVClient = clientTestingKnobs
- params.DefaultTestTenant = base.TestDoesNotWorkWithExternalProcessMode(156333)
+ params.DefaultTestTenant = base.ExternalTestTenantAlwaysEnabled
srv, sqlDB, _ := serverutils.StartServer(t, params)
defer srv.Stopper().Stop(context.Background())
s = srv.ApplicationLayer()
It occasionally fails with
=== RUN TestReacquireLeaseOnRestart
test_log_scope.go:171: test logs captured to: /Users/yuzefovich/go/src/github.com/cockroachdb/cockroach/tmp/_tmp/a16775d7a628eb0b950c24e9004c9a4a/logTestReacquireLeaseOnRestart3826452634
test_log_scope.go:82: use -show-logs to present logs inline
txn_restart_test.go:1322: dial tcp 127.0.0.1:61343: connect: connection reset by peer
Jira issue: CRDB-55945
Metadata
Metadata
Assignees
Labels
Relating to MVCC and the transactional model.Related to multi-tenancyTesting tools and infrastructureCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Further steps needed to qualify. C-label will change.Broken test (automatically or manually discovered).KV TeamFailures and bugs on the master branch.