Skip to content

skip PK check, filter path JSON #19940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

taroface
Copy link
Contributor

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 8b75f84
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/68792fa75e5ec10008454581

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 8b75f84
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/68792fa754cc5b000844ef16

Copy link

github-actions bot commented Jul 15, 2025

Files changed:

Copy link

netlify bot commented Jul 15, 2025

Netlify Preview

Name Link
🔨 Latest commit 8b75f84
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/68792fa7d468fe000800dd60
😎 Deploy Preview https://deploy-preview-19940--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@Jeremyyang920 Jeremyyang920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the one comment lgtm

`--skip-pk-match` removes the [requirement that source and target tables share matching primary keys](#exit-early) for data load. When this flag is set:

- The data load proceeds even if the source or target table lacks a primary key, or if their keys do not match.
- Sharding is disabled. Each table is exported in a single batch within one shard, bypassing `--export-concurrency` and `--row-batch-size`. As a result, memory usage and execution time may increase due to full table scans.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Sharding is disabled. Each table is exported in a single batch within one shard, bypassing `--export-concurrency` and `--row-batch-size`. As a result, memory usage and execution time may increase due to full table scans.
- When `--skip-pk-match` is set, sharding is disabled. Each table is exported in a single batch within one shard, bypassing `--export-concurrency` and `--row-batch-size`. As a result, memory usage and execution time may increase due to full table scans.

@ZhouXing19
Copy link
Contributor

Thanks for working on this!

@taroface taroface requested a review from florence-crl July 16, 2025 22:03
Copy link

@ryanluu12345 ryanluu12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only questions are about the example output rows + the default comment Jane mentioned (should mention it's false - off, by default)

Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants