refactor: fix remaining lint problems after update

Author: matejchalk

package-lock.json

@@ -25,6 +25,7 @@ export default tseslint.config(
     files: ['**/*.test.ts'],
     rules: {
       'vitest/max-nested-describe': ['warn', { max: 3 }],
+      'n/no-unsupported-features/node-builtins': 'off',
     },
   },
 );

packages/ci/eslint.config.js

@@ -9,8 +9,7 @@ import {
   eslintConfigFromNxProjectAndDeps,
 } from './nx/index.js';
 
-const ALL_PROJECTS = ['cli', 'core', 'nx-plugin', 'utils'] as const;
-type Project = (typeof ALL_PROJECTS)[number];
+type Project = 'cli' | 'core' | 'nx-plugin' | 'utils';
 
 describe('Nx helpers', () => {
   let cwdSpy: MockInstance<[], string>;

packages/plugin-eslint/src/lib/nx.integration.test.ts

@@ -129,7 +129,7 @@ async function processAudit(
 
   const rejected = auditResults.filter(isPromiseRejectedResult);
   if (rejected.length > 0) {
-    rejected.map(result => {
+    rejected.forEach(result => {
       console.error(result.reason);
     });
 

packages/plugin-js-packages/src/lib/runner/index.ts

@@ -23,6 +23,9 @@
     "access": "public"
   },
   "type": "module",
+  "engines": {
+    "node": ">=17.0.0"
+  },
   "dependencies": {
     "@code-pushup/models": "0.56.0",
     "@isaacs/cliui": "^8.0.2",

packages/utils/package.json

@@ -237,34 +237,31 @@ export function compareIssues(a: Issue, b: Issue): number {
   if (a.severity !== b.severity) {
     return -compareIssueSeverity(a.severity, b.severity);
   }
-
   if (!a.source && b.source) {
     return -1;
   }
-
   if (a.source && !b.source) {
     return 1;
   }
-
   if (a.source?.file !== b.source?.file) {
     return a.source?.file.localeCompare(b.source?.file || '') ?? 0;
   }
+  return compareSourceFilePosition(a.source?.position, b.source?.position);
+}
 
-  if (!a.source?.position && b.source?.position) {
+function compareSourceFilePosition(
+  a: NonNullable<Issue['source']>['position'],
+  b: NonNullable<Issue['source']>['position'],
+): number {
+  if (!a && b) {
     return -1;
   }
-
-  if (a.source?.position && !b.source?.position) {
+  if (a && !b) {
     return 1;
   }
-
-  if (a.source?.position?.startLine !== b.source?.position?.startLine) {
-    return (
-      (a.source?.position?.startLine ?? 0) -
-      (b.source?.position?.startLine ?? 0)
-    );
+  if (a?.startLine !== b?.startLine) {
+    return (a?.startLine ?? 0) - (b?.startLine ?? 0);
   }
-
   return 0;
 }
 

packages/utils/src/lib/reports/utils.ts

@@ -1,5 +1,6 @@
 // the point is to test runtime import which relies on alias defined in tsconfig.json "paths"
 // non-type import from '@example/custom-plugin' wouldn't work without --tsconfig
+// eslint-disable-next-line import/no-unresolved
 import customPlugin from '@example/custom-plugin';
 
 const config = {