Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: nx-plugin with v2 format #971

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

feat: nx-plugin with v2 format #971

wants to merge 20 commits into from

Conversation

aramirezj
Copy link
Contributor

@aramirezj aramirezj commented Mar 9, 2025 •
edited by BioPhoton
Loading

closes #881

@aramirezj aramirezj requested a review from BioPhoton as a code owner March 9, 2025 20:47
@github-actions github-actions bot removed the 🔬 testing writing tests label Mar 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2025 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit b03db63 with previous commit b03db63.

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 51 🔴 47 ↓ −3.2
Code coverage 🟢 90 🟢 90 –
Security 🟡 67 🟡 67 –
Updates 🟡 81 🟡 81 –
Accessibility 🟢 92 🟢 92 –
Best Practices 🟢 100 🟢 100 –
SEO 🟡 61 🟡 61 –
Bug prevention 🟢 100 🟢 100 –
Code style 🟢 100 🟢 100 –
Documentation 🔴 23 🔴 23 –
👎 1 group regressed, 👍 2 audits improved, 👎 3 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 51 🔴 47 ↓ −3.2

17 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟨 5.3 s 🟥 7.0 s ↑ +32.6 %
Lighthouse Time to Interactive 🟥 12.0 s 🟥 14.0 s ↑ +17.5 %
Lighthouse Total Blocking Time 🟥 2,310 ms 🟥 6,290 ms ↑ +172.1 %
Lighthouse First Contentful Paint 🟥 3.0 s 🟨 2.9 s ↓ −4.2 %
Lighthouse Largest Contentful Paint 🟨 3.8 s 🟨 3.8 s ↓ −1.2 %
Lighthouse Minimizes main-thread work 🟥 11.5 s 🟥 19.5 s ↑ +69.4 %
Lighthouse JavaScript execution time 🟥 5.1 s 🟥 7.8 s ↑ +53.7 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +17.5 %
Lighthouse Max Potential First Input Delay 🟥 1,370 ms 🟥 2,680 ms ↑ +96.3 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,000 ms 🟥 Potential savings of 490 ms ↓ −51.4 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Server Backend Latencies 🟩 180 ms 🟩 230 ms ↑ +26.7 %
Lighthouse Initial server response time was short 🟩 Root document took 380 ms 🟩 Root document took 400 ms ↑ +6.8 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,832 KiB 🟩 Total size was 1,832 KiB ↓ −0.1 %
Lighthouse Network Round Trip Times 🟩 60 ms 🟩 60 ms ↓ −2.4 %

581 other audits are unchanged.

BioPhoton
BioPhoton requested changes Mar 9, 2025
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Soon we have it working for latest Nx.
We could add a test for the normalize function.

@aramirezj aramirezj changed the title feat: mvp nx-plugin with v2 format feat: nx-plugin with v2 format Mar 9, 2025
@vmasek
Copy link
Collaborator

vmasek commented Mar 10, 2025

From what I understood we are keeping both legacy and V2 for backwards compatibility.

Looks good so far, I'll watch this as this is now to only blocker for moving to latest Nx.
It will also unlock latest vitest which I'm looking forward updating to 👍🏻

@vmasek vmasek mentioned this pull request Mar 10, 2025
Merged
@BioPhoton
Copy link
Collaborator

From what I understood we are keeping both legacy and V2 for backwards compatibility.

Looks good so far, I'll watch this as this is now to only blocker for moving to latest Nx. It will also unlock latest vitest which I'm looking forward updating to 👍🏻

There is one thing left and that is considering projec.json AND package.json

@github-actions github-actions bot added the 🔬 testing writing tests label Mar 10, 2025
BioPhoton
BioPhoton requested changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added changes for file extensions

@aramirezj aramirezj requested a review from BioPhoton March 10, 2025 21:52
BioPhoton
BioPhoton previously approved these changes Mar 10, 2025
View reviewed changes
@BioPhoton BioPhoton mentioned this pull request Mar 10, 2025
Closed
@github-actions github-actions bot added the 📖 Project documentation improvements or additions to the project documentation label Mar 11, 2025
vmasek
vmasek reviewed Mar 20, 2025
View reviewed changes
e2e/nx-plugin-e2e/tests/plugin-derive-config.e2e.test.ts Outdated
});

afterEach(async () => {
// await teardownTestFolder(testFileDir);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably a leftover change from debugging

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmasek vmasek vmasek left review comments

@BioPhoton BioPhoton BioPhoton left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@aramirezj aramirezj

Labels
🧩 nx-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement create nodes V2 API for the nx-plugin project
3 participants
@aramirezj @vmasek @BioPhoton