-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Player team and role selection #51
Draft
whois-jon-peterson
wants to merge
60
commits into
dev
Choose a base branch
from
player_team_and_role_selection
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whois-jon-peterson
added
enhancement
New feature or request
Server
Issues and PRs relating to the server application
labels
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #44
Adds server-side websockets interface to support players selecting teams and roles while waiting on the Lobby screen. As part of this change, the server will no longer immediately initialize the game as soon as the last player subscribes to the channel. Instead, the UI will need to send a
start-game
message as defined in the README.Adds support for the following websocket actions (to be added to
createCable()
inApp/index.js
:These are documented in the README with the expected team/role objects.
Adds player role and team to the
player-joined
broadcast, and adds a newplayer-update
broadcast which is sent after processing a player's team or role selection. These properties (isBlueTeam
andisIntel
) can benull
if the player has not selected their role/team yet, or boolean to indicate the appropriate role/team.Adds a
category
property to theillegal-action
message. The keywords "personal", "public", and "info" have been reserved for use.console.warn()
for other players)console.warn()
At this time, all
illegal-action
s just use the "personal" category.Type of change
Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration:
Extensive testing to cover a variety of situations. See
player_selections_spec.rb
If so, please explain:
Backfilled missing tests for earlier untested changes.
Adjusted tests that assumed game would automatically be established after last player subscribes. Affected tests now manually establish the game after all players are in.
Additional notes:
NA
Checklist: