♻️ Added missing tests

Author: ruslansteiger

src/FlysystemCloudinaryAdapter.php

@@ -379,23 +379,7 @@ public function getMimetype($path): array | false
     {
         ray('adapter getMimetype');
 
-        $contents = $this->read($path);
-
-        $temp = tmpfile();
-
-        fwrite($temp, $contents['contents']);
-
-        $mime = mime_content_type($temp);
-
-        fclose($temp);
-
-        if ($mime === false) {
-            return false;
-        }
-
-        return [
-            'mimetype' => $mime,
-        ];
+        return $this->getMetadata($path);
     }
 
     /**
@@ -405,7 +389,7 @@ public function getTimestamp($path): array | false
     {
         ray('adapter getTimestamp');
 
-        return $this->getMimetype($path);
+        return $this->getMetadata($path);
     }
 
     public function getUrl(string $path): string

tests/Feature/FlysystemCloudinaryAdapterTest.php

@@ -294,6 +294,91 @@ public function it_does_get_metadata()
 
         $meta = $this->adapter->getMetadata($publicId);
 
+        $this->assertMetadataResponse($meta, $publicId);
+        $this->adapter->delete($publicId); // cleanup
+    }
+
+    /** @test */
+    public function it_does_not_get_metadata_if_file_is_not_found()
+    {
+        $publicId = 'file-does-not-exist';
+
+        $bool = $this->adapter->getMetadata($publicId);
+
+        $this->assertFalse($bool);
+    }
+
+    /** @test */
+    public function it_does_get_size()
+    {
+        $publicId = 'file-get-size-' . rand();
+        $fakeImage = File::image('black.jpg')->getContent();
+        $this->adapter->write($publicId, $fakeImage, new Config());
+
+        $meta = $this->adapter->getSize($publicId);
+
+        $this->assertMetadataResponse($meta, $publicId);
+        $this->adapter->delete($publicId); // cleanup
+    }
+
+    /** @test */
+    public function it_does_not_get_size_if_file_is_not_found()
+    {
+        $publicId = 'file-does-not-exist';
+
+        $bool = $this->adapter->getSize($publicId);
+
+        $this->assertFalse($bool);
+    }
+
+    /** @test */
+    public function it_does_get_mimetype()
+    {
+        $publicId = 'file-get-mimetype-' . rand();
+        $fakeImage = File::image('black.jpg')->getContent();
+        $this->adapter->write($publicId, $fakeImage, new Config());
+
+        $meta = $this->adapter->getMimetype($publicId);
+
+        $this->assertMetadataResponse($meta, $publicId);
+        $this->adapter->delete($publicId); // cleanup
+    }
+
+    /** @test */
+    public function it_does_not_get_mimetype_if_file_is_not_found()
+    {
+        $publicId = 'file-does-not-exist';
+
+        $bool = $this->adapter->getMimetype($publicId);
+
+        $this->assertFalse($bool);
+    }
+
+    /** @test */
+    public function it_does_get_timestamp()
+    {
+        $publicId = 'file-get-mimetype-' . rand();
+        $fakeImage = File::image('black.jpg')->getContent();
+        $this->adapter->write($publicId, $fakeImage, new Config());
+
+        $meta = $this->adapter->getTimestamp($publicId);
+
+        $this->assertMetadataResponse($meta, $publicId);
+        $this->adapter->delete($publicId); // cleanup
+    }
+
+    /** @test */
+    public function it_does_not_get_timestamp_if_file_is_not_found()
+    {
+        $publicId = 'file-does-not-exist';
+
+        $bool = $this->adapter->getTimestamp($publicId);
+
+        $this->assertFalse($bool);
+    }
+
+    protected function assertMetadataResponse(array $meta, string $publicId): void
+    {
         $this->assertIsString($meta['contents']);
         $this->assertNull($meta['etag']);
         $this->assertSame('image/jpeg', $meta['mimetype']);
@@ -304,6 +389,18 @@ public function it_does_get_metadata()
         $this->assertIsInt($meta['version']);
         $this->assertIsString($meta['versionid']);
         $this->assertSame('public', $meta['visibility']);
+    }
+
+    /** @test */
+    public function it_does_get_url()
+    {
+        $publicId = 'file-get-url-' . rand();
+        $fakeImage = File::image('black.jpg')->getContent();
+        $this->adapter->write($publicId, $fakeImage, new Config());
+
+        $url = $this->adapter->getUrl($publicId);
+
+        $this->assertStringContainsString($publicId, $url);
         $this->adapter->delete($publicId); // cleanup
     }
 }