From 860dc43122c17b403287b3f583757396071749c1 Mon Sep 17 00:00:00 2001 From: Tom McLaughlin Date: Fri, 8 Nov 2024 04:23:08 -0800 Subject: [PATCH] Don't put colons in error symlink names. It caused in error when trying to use actions/upload-artifact@v4 in GitHub Actions. It says certain characters are disallowed in order to maintain compatibility with filesystems like NTFS. Maybe we should even filter all our on-disk paths to remove this. According to the error message, they are ":<>|*?\r\n --- sandwich/src/Test/Sandwich/Interpreters/StartTree.hs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sandwich/src/Test/Sandwich/Interpreters/StartTree.hs b/sandwich/src/Test/Sandwich/Interpreters/StartTree.hs index e29b8c70..7e82fdec 100644 --- a/sandwich/src/Test/Sandwich/Interpreters/StartTree.hs +++ b/sandwich/src/Test/Sandwich/Interpreters/StartTree.hs @@ -222,7 +222,7 @@ runInAsync node ctx action = do whenJust baseContextRunRoot $ \runRoot -> do let symlinkBaseName = case runTreeLoc of Nothing -> takeFileName dir - Just loc -> [i|#{srcLocFile loc}:#{srcLocStartLine loc}_#{takeFileName dir}|] + Just loc -> [i|#{srcLocFile loc}_line#{srcLocStartLine loc}_#{takeFileName dir}|] let symlinkPath = errorsDir (nodeToFolderName symlinkBaseName 9999999 runTreeId) -- Delete the symlink if it's already present. This can happen when re-running