Skip to content

Commit 7c0ed59

Browse files
authored
Drop support for Node 16.x (eclipse-theia#14027)
Fixes eclipse-theia#13956 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
1 parent 004e2b2 commit 7c0ed59

12 files changed

+25
-21
lines changed

.github/workflows/ci-cd.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ jobs:
2020
- name: Checkout
2121
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
2222

23-
- name: Use Node.js 18.x
23+
- name: Use Node.js 20.x
2424
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
2525
with:
26-
node-version: 18.x
26+
node-version: 20.x
2727
registry-url: 'https://registry.npmjs.org'
2828

2929
- name: Use Python 3.11
@@ -52,7 +52,7 @@ jobs:
5252
fail-fast: false
5353
matrix:
5454
os: [windows-2019, ubuntu-latest, macos-14]
55-
node: [16.x, 18.x, 20.x]
55+
node: [18.x, 20.x]
5656

5757
runs-on: ${{ matrix.os }}
5858
timeout-minutes: 60

.github/workflows/license-check.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
fail-fast: false
2121
matrix:
2222
os: [ubuntu-latest]
23-
node: ['18.x']
23+
node: ['20.x']
2424
java: ['11']
2525

2626
runs-on: ${{ matrix.os }}

.github/workflows/performance-tests.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ jobs:
1414
- name: Checkout
1515
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
1616

17-
- name: Use Node.js 18.x
17+
- name: Use Node.js 20.x
1818
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
1919
with:
20-
node-version: "18.x"
20+
node-version: "20.x"
2121
registry-url: "https://registry.npmjs.org"
2222

2323
- name: Use Python 3.11

.github/workflows/playwright.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ jobs:
2222
- name: Checkout
2323
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
2424

25-
- name: Use Node.js "18.x"
25+
- name: Use Node.js "20.x"
2626
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
2727
with:
28-
node-version: "18.x"
28+
node-version: "20.x"
2929
registry-url: "https://registry.npmjs.org"
3030

3131
- name: Use Python 3.11

.github/workflows/production-smoke-test.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ jobs:
2020
- name: Checkout
2121
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
2222

23-
- name: Use Node.js "18.x"
23+
- name: Use Node.js "20.x"
2424
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
2525
with:
26-
node-version: "18.x"
26+
node-version: "20.x"
2727
registry-url: "https://registry.npmjs.org"
2828

2929
- name: Use Python 3.11

.github/workflows/publish-gh-pages.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ jobs:
1919
with:
2020
fetch-depth: 0 # To fetch all history for all branches and tags. (Will be required for caching with lerna: https://github.com/markuplint/markuplint/pull/111)
2121

22-
- name: Use Node.js 18.x
22+
- name: Use Node.js 20.x
2323
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
2424
with:
25-
node-version: '18.x'
25+
node-version: '20.x'
2626
registry-url: 'https://registry.npmjs.org'
2727

2828
- name: Use Python 3.x

.github/workflows/publish-next.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ jobs:
1818
# Required for lerna to determine the version of the next package.
1919
fetch-depth: 0
2020

21-
- name: Use Node.js 18.x
21+
- name: Use Node.js 20.x
2222
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
2323
with:
24-
node-version: 18.x
24+
node-version: 20.x
2525
registry-url: "https://registry.npmjs.org"
2626

2727
- name: Use Python 3.11

.github/workflows/publish-release.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ jobs:
2424
- name: Checkout
2525
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
2626

27-
- name: Use Node.js 18.x
27+
- name: Use Node.js 20.x
2828
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
2929
with:
30-
node-version: 18.x
30+
node-version: 20.x
3131
registry-url: "https://registry.npmjs.org"
3232

3333
- name: Use Python 3.11

.github/workflows/translation.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ jobs:
1212
- name: Checkout
1313
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
1414

15-
- name: Use Node.js 18.x
15+
- name: Use Node.js 20.x
1616
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
1717
with:
18-
node-version: 18.x
18+
node-version: 20.x
1919
registry-url: "https://registry.npmjs.org"
2020

2121
- name: Use Python 3.x

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44

55
- [Previous Changelogs](https://github.com/eclipse-theia/theia/tree/master/doc/changelogs/)
66

7+
<a name="breaking_changes_1.53.0">[Breaking Changes:](#breaking_changes_1.51.0)</a>
8+
- [dependencies] increased minimum node version to 18. [#14027](https://github.com/eclipse-theia/theia/pull/14027) - Contributed on behalf of STMicroelectronics
9+
10+
711
## 1.52.0 - 07/25/2024
812

913
- [application-package] bumped the default supported API from `1.90.2` to `1.91.1` [#13955](https://github.com/eclipse-theia/theia/pull/13955) - Contributed on behalf of STMicroelectronics

doc/Developing.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -508,7 +508,7 @@ etc.) by opening `packages/<package name>/coverage/index.html`.
508508

509509
- Install [`scoop`](https://github.com/lukesampson/scoop#installation).
510510
- Install [`nvm`](https://github.com/coreybutler/nvm-windows) with scoop: `scoop install nvm`.
511-
- Install Node.js with `nvm`: `nvm install 18.17.0`, then use it: `nvm use 18.17.0`. You can list all available Node.js versions with `nvm list available` if you want to pick another version.
511+
- Install Node.js with `nvm`: `nvm install lts`, then use it: `nvm use lts`. You can list all available Node.js versions with `nvm list available` if you want to pick another version.
512512
- Install `yarn`: `scoop install yarn`.
513513
- If you need to install `windows-build-tools`, see [`Installing Windows Build Tools`](#installing-windows-build-tools).
514514
- If you run into problems with installing the required build tools, the `node-gyp` documentation offers a useful [guide](https://github.com/nodejs/node-gyp#on-windows) how to install the dependencies manually. The versions required for building Theia are:

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"version": "0.0.0",
55
"engines": {
66
"yarn": ">=1.7.0 <2",
7-
"node": ">=16"
7+
"node": ">=18"
88
},
99
"resolutions": {
1010
"**/@types/node": "18"
@@ -114,4 +114,4 @@
114114
"vscode.microsoft-authentication",
115115
"ms-vscode.references-view"
116116
]
117-
}
117+
}

0 commit comments

Comments
 (0)