refactor: remove unused config parameter and streamline package export handling in update-exports command and use case

Author: thevuong

packages/cli/src/application/commands/update-exports.command.ts

@@ -3,7 +3,6 @@ import { inject, injectable } from "inversify";
 import * as process from "node:process";
 
 import type { UpdateExportsUseCase } from "@/application/use-cases/update-exports.use-case";
-import type { ScriptConfig } from "@/domain/entities/package-config";
 
 import { TYPES } from "@/ioc/types";
 
@@ -13,25 +12,22 @@ export class UpdateExportsCommand {
 
   /**
    * Returns a Commander.js command for updating package exports.
-   * @param config - Script configuration for package export patterns.
+   *
    * @returns Configured Commander.js command.
    */
-  getCommand(config: ScriptConfig): Command {
+  getCommand(): Command {
     return new Command()
       .name("update-exports")
       .description("Updates exports for all packages")
       .option("-p, --package <package>", "Filter by package name")
       .option("-d, --dry-run", "Run without making changes")
       .option("-c, --config <path>", "Path to configuration file")
       .action(async (options: { config?: string; dryRun?: string; package?: string }) => {
-        await this.updateExportsUseCase.execute(
-          {
-            packageFilter: options.package,
-            dryRun: Boolean(options.dryRun),
-            configPath: options.config,
-          },
-          config,
-        );
+        await this.updateExportsUseCase.execute({
+          packageFilter: options.package,
+          dryRun: Boolean(options.dryRun),
+          configPath: options.config,
+        });
 
         process.exit(0);
       });

packages/cli/src/application/use-cases/update-exports.use-case.ts

@@ -1,6 +1,5 @@
 import { inject, injectable } from "inversify";
 
-import type { ScriptConfig } from "@/domain/entities/package-config";
 import type { PackageRepository } from "@/domain/interfaces/package.repository";
 
 import { handleError } from "@/application/utilities/error-handler";
@@ -13,23 +12,19 @@ export class UpdateExportsUseCase {
   /**
    * Updates exports for all packages based on provided options and configuration.
    * @param options - Options for dry run, config path, and package filter.
-   * @param config - Script configuration for package export patterns.
    */
-  async execute(
-    options: { dryRun: boolean; configPath?: string; packageFilter?: string },
-    config: ScriptConfig,
-  ): Promise<void> {
+  async execute(options: { dryRun: boolean; configPath?: string; packageFilter?: string }): Promise<void> {
     try {
-      console.info("Searching for packages...");
-      const packageJsonPaths = await this.packageRepository.findAllPackages(config);
+      console.info("♢‒ Searching for packages...");
+      const packageJsonPaths = await this.packageRepository.findAllPackages(options.configPath);
 
       if (packageJsonPaths.length === 0) {
         console.warn("No packages found.");
 
         return;
       }
 
-      console.log(`Found ${packageJsonPaths.length} packages.`);
+      console.log(` Found ${packageJsonPaths.length} packages.`);
 
       let successCount = 0;
       let skipCount = 0;
@@ -47,7 +42,7 @@ export class UpdateExportsUseCase {
         }
       }
 
-      console.log("Completed exports update.");
+      console.log("♢‒ Completed exports update.\n");
       console.info(`Stats: ${successCount} succeeded, ${skipCount} skipped, ${errorCount} failed`);
     } catch (error) {
       handleError(error, "Error processing packages");

packages/cli/src/infrastructure/repositories/file-system-package.repository.ts

@@ -5,11 +5,17 @@ import path from "node:path";
 
 import type { AnalysisPort } from "@/application/ports/analysis.port";
 import type { FileSystemPort } from "@/application/ports/file-system.port";
-import type { AnalysisResult, PackageConfig, PackageExports, ScriptConfig } from "@/domain/entities/package-config";
+import type {
+  AnalysisResult,
+  PackageConfig,
+  PackageExports,
+  PackageJson,
+  ScriptConfig,
+} from "@/domain/entities/package-config";
 import type { PackageRepository } from "@/domain/interfaces/package.repository";
 import type { FileSystemUtility } from "@/infrastructure/utilities/file-system-utility";
 
-import { packageJsonSchema, scriptConfigSchema } from "@/domain/entities/package-config";
+import { scriptConfigSchema } from "@/domain/entities/package-config";
 import { TYPES } from "@/ioc/types";
 
 @injectable()
@@ -42,7 +48,9 @@ export class FileSystemPackageRepository implements PackageRepository {
     @inject(TYPES.FileSystemUtility) private fileSystemUtility: FileSystemUtility,
   ) {}
 
-  async findAllPackages(config: ScriptConfig): Promise<string[]> {
+  async findAllPackages(configPath?: string): Promise<string[]> {
+    const config = this.getConfig(configPath);
+
     return await glob(config.packagesGlob, {
       ignore: this.DEFAULT_IGNORE_PATTERN,
     });
@@ -60,7 +68,7 @@ export class FileSystemPackageRepository implements PackageRepository {
     let packageJson;
 
     try {
-      packageJson = packageJsonSchema.parse(JSON.parse(this.fileSystemPort.readFile(packageJsonPath)));
+      packageJson = JSON.parse(this.fileSystemPort.readFile(packageJsonPath)) as PackageJson;
     } catch (error) {
       console.error(`Failed to parse ${packageJsonPath}: ${error instanceof Error ? error.message : "Unknown error"}`);
 
@@ -75,28 +83,28 @@ export class FileSystemPackageRepository implements PackageRepository {
       return false;
     }
 
-    console.info(`Processing package: ${packageName}`);
+    console.info(`♢‒ Processing package: ${packageName}`);
 
     const config = this.getConfig(options.configPath);
     const packageConfig = this.getPackageConfig(packageName, config);
     const srcIndexPath = path.join(packageDir, packageConfig.srcIndexPath);
 
     if (!this.fileSystemPort.exists(srcIndexPath)) {
-      console.error(`Source file not found at ${srcIndexPath}`);
+      console.error(`⎹  ⛔︎ Source file not found at ${srcIndexPath}`);
 
       return false;
     }
 
-    console.info(`Analyzing imports from ${srcIndexPath}...`);
+    console.info(`⎹  Analyzing imports from ${srcIndexPath}...`);
     const analysis = this.analyzeImports(srcIndexPath, packageConfig);
 
     if (analysis.imports.length === 0) {
-      console.warn(`No imports found to analyze in ${packageName}`);
+      console.warn(`⎹  ⛔︎ No imports found to analyze in ${packageName}`);
 
       return false;
     }
 
-    console.log(`Analysis complete. Found ${analysis.imports.length} subpath exports.`);
+    console.log(`⎹  Analysis complete. Found ${analysis.imports.length} subpath exports.`);
 
     this.saveExportsAnalysis(packageDir, analysis);
 
@@ -105,23 +113,23 @@ export class FileSystemPackageRepository implements PackageRepository {
     const currentExportsCount = packageJson.exports ? Object.keys(packageJson.exports).length : 0;
     const newExportsCount = Object.keys(newExports).length;
 
-    console.info(`Exports: ${currentExportsCount} -> ${newExportsCount}`);
+    console.info(`⎹  Exports: ${currentExportsCount} -> ${newExportsCount}`);
 
     if (options.dryRun) {
       this.saveExportsPreview(packageDir, newExports);
-      console.warn(`Saved exports preview to .exports-analysis`);
-      console.warn(`Dry run: no changes saved for ${packageName}`);
+      console.warn(`⎹  Saved exports preview to .exports-analysis`);
+      console.warn(`⎹  Dry run: no changes saved for ${packageName}`);
 
       return true;
     }
 
     this.fileSystemUtility.backupFile(packageJsonPath, ".exports-analysis");
-    console.log(`Backed up ${packageJsonPath}`);
+    console.log(`⎹  Backed up ${packageJsonPath}`);
 
     const updatedPackageJson = { ...packageJson, exports: newExports };
 
-    this.fileSystemPort.writeFile(packageJsonPath, JSON.stringify(updatedPackageJson, null, 2));
-    console.log(`Updated exports for ${packageName}`);
+    this.fileSystemPort.writeFile(packageJsonPath, `${JSON.stringify(updatedPackageJson, null, 2)}\n`);
+    console.log(`⎹  Updated exports for ${packageName}`);
 
     return true;
   }