Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i think parent of injector should be pointer #28

Closed
win-t opened this issue Jul 12, 2015 · 2 comments
Closed

i think parent of injector should be pointer #28

win-t opened this issue Jul 12, 2015 · 2 comments

Comments

@win-t
Copy link

win-t commented Jul 12, 2015

type Injector interface {
    Applicator
    Invoker
    TypeMapper
    // SetParent sets the parent of the injector. If the injector cannot find a
    // dependency in its Type map it will check its parent before returning an
    // error.
    SetParent(*Injector) // <-- we need reference to parent, not a copy of parent
}

what do you think?

@win-t
Copy link
Author

win-t commented Jul 12, 2015

forget it, i made mistake,

@win-t win-t closed this as completed Jul 12, 2015
@berkaroad
Copy link

just use parent's method, not share any variables, so it is not nessisary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants