JUnit Jupiter best practices

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.testing.junit.JupiterBestPractices?organizationId=NzQ1YmJlODUtZjNkMy00OTNkLThhNDAtZWJmZDg4N2U1ZjU1

Co-authored-by: Moderne <[email protected]>

Author: slachiewicz

src/test/java/org/codehaus/plexus/components/secdispatcher/internal/DefaultSecDispatcherTest.java

@@ -42,7 +42,7 @@
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-public class DefaultSecDispatcherTest {
+class DefaultSecDispatcherTest {
     private final Path CONFIG_PATH = Paths.get("./target/sec.xml");
 
     private void saveSec(String dispatcher, Map<String, String> config) throws Exception {

src/test/java/org/codehaus/plexus/components/secdispatcher/internal/SecUtilTest.java

@@ -36,7 +36,7 @@
  * @version $Id$
  *
  */
-public class SecUtilTest {
+class SecUtilTest {
     String _confName = "cname";
     String _propName = "pname";
     String _propVal = "pval";
@@ -64,7 +64,7 @@ void prepare() throws IOException {
     }
 
     @Test
-    void readWrite() throws IOException {
+    void readWrite() throws Exception {
         Path path = Path.of("./target/sec.xml");
         SettingsSecurity config = SecUtil.read(path);
         assertNotNull(config);
@@ -75,7 +75,7 @@ void readWrite() throws IOException {
     }
 
     @Test
-    void readWriteWithBackup() throws IOException {
+    void readWriteWithBackup() throws Exception {
         Path path = Path.of("./target/sec.xml");
         SettingsSecurity config = SecUtil.read(path);
         assertNotNull(config);

src/test/java/org/codehaus/plexus/components/secdispatcher/internal/cipher/CipherTestSupport.java

@@ -41,7 +41,7 @@ void prepare() {
     abstract Cipher getCipher();
 
     @Test
-    void testEncrypt() throws Exception {
+    void encrypt() throws Exception {
         String enc = pbeCipher.encrypt(clearText, password);
         assertNotNull(enc);
         String enc2 = pbeCipher.encrypt(clearText, password);
@@ -50,14 +50,14 @@ void testEncrypt() throws Exception {
     }
 
     @Test
-    void testDecrypt() throws Exception {
+    void decrypt() throws Exception {
         String enc = pbeCipher.encrypt(clearText, password);
         String clear = pbeCipher.decrypt(enc, password);
         assertEquals(clearText, clear);
     }
 
     @Test
-    void testEncoding() throws Exception {
+    void encoding() throws Exception {
         String pwd = "äüöÜÖÄæøåčćžšđß\"§$%&/()=?é";
         String encPwd = pbeCipher.encrypt(pwd, pwd);
         String decPwd = pbeCipher.decrypt(encPwd, pwd);

src/test/java/org/codehaus/plexus/components/secdispatcher/internal/dispatchers/LegacyDispatcherTest.java

@@ -20,7 +20,7 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
-public class LegacyDispatcherTest {
+class LegacyDispatcherTest {
     /**
      * Test values created with Maven 3.9.9.
      * <p>

src/test/java/org/codehaus/plexus/components/secdispatcher/internal/dispatchers/MasterSourceLookupDispatcherTest.java

@@ -25,10 +25,10 @@
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-public class MasterSourceLookupDispatcherTest {
+class MasterSourceLookupDispatcherTest {
 
     @Test
-    void testUnknownPrefix() {
+    void unknownPrefix() {
         MasterSourceLookupDispatcher masterSourceLookupDispatcher =
                 new MasterSourceLookupDispatcher(Collections.singleton(new EnvMasterSource()));
         assertThrows(
@@ -40,7 +40,7 @@ void testUnknownPrefix() {
     }
 
     @Test
-    void testSystemPropertyMasterSourceDecrypt() {
+    void systemPropertyMasterSourceDecrypt() {
         System.setProperty("myprop", "plaintext");
         MasterSourceLookupDispatcher masterSourceLookupDispatcher =
                 new MasterSourceLookupDispatcher(Collections.singleton(new SystemPropertyMasterSource()));
@@ -50,7 +50,7 @@ void testSystemPropertyMasterSourceDecrypt() {
     }
 
     @Test
-    void testEncrypt() {
+    void encrypt() {
         System.setProperty("myprop", "plaintext");
         MasterSourceLookupDispatcher masterSourceLookupDispatcher =
                 new MasterSourceLookupDispatcher(Collections.singleton(new SystemPropertyMasterSource()));
@@ -60,7 +60,7 @@ void testEncrypt() {
     }
 
     @Test
-    void testValidateConfiguration() {
+    void validateConfiguration() {
         MasterSourceLookupDispatcher masterSourceLookupDispatcher =
                 new MasterSourceLookupDispatcher(Collections.singleton(new SystemPropertyMasterSource()));
         ValidationResponse response = masterSourceLookupDispatcher.validateConfiguration(Collections.emptyMap());

src/test/java/org/codehaus/plexus/components/secdispatcher/internal/sources/SourcesTest.java

@@ -21,7 +21,7 @@
 /**
  * surefire plugin set system property and env.
  */
-public class SourcesTest {
+class SourcesTest {
     @Test
     void systemProperty() {
         SystemPropertyMasterSource source = new SystemPropertyMasterSource();