Skip to content

Commit e074124

Browse files
authored
Embed fixes
2 parents 5c509a7 + 367f3be commit e074124

File tree

3 files changed

+45
-35
lines changed

3 files changed

+45
-35
lines changed

filebrowser.js

-5
Original file line numberDiff line numberDiff line change
@@ -911,11 +911,6 @@ async function clickedOnFileHTML(fileEl, event) {
911911
// update bottom float
912912
updateFloat();
913913

914-
} else if (!liveView.classList.contains('file-open')) {
915-
916-
// hide sidebar
917-
toggleSidebar(false);
918-
919914
}
920915

921916
}

live-view/live-view.js

+43-28
Original file line numberDiff line numberDiff line change
@@ -599,35 +599,50 @@ if (isMobile) {
599599

600600
// pop out live view to new window
601601

602+
if (!isEmbed) {
602603

603-
// get live view URL
604-
const liveViewURL = livePath +'?'+ workerClientId +'/';
605-
606-
// open a new window with live view URL
607-
window.open(liveViewURL, '_blank');
608-
609-
610-
// close inline live view
611-
612-
liveViewToggle = !liveViewToggle;
613-
614-
// clear live view
615-
liveView.innerHTML = '';
616-
617-
// show loader
618-
liveView.classList.remove('loaded');
619-
620-
621-
// don't transition live view
622-
liveView.classList.add('notransition');
623-
624-
// hide live view
625-
liveView.classList.remove('visible');
626-
627-
// restore transition on next frame
628-
onNextFrame(() => {
629-
liveView.classList.remove('notransition');
630-
});
604+
// get live view URL
605+
const liveViewURL = livePath +'?'+ workerClientId +'/';
606+
607+
// open a new window with live view URL
608+
window.open(liveViewURL, '_blank');
609+
610+
611+
// close inline live view
612+
613+
liveViewToggle = !liveViewToggle;
614+
615+
// clear live view
616+
liveView.innerHTML = '';
617+
618+
// show loader
619+
liveView.classList.remove('loaded');
620+
621+
622+
// don't transition live view
623+
liveView.classList.add('notransition');
624+
625+
// hide live view
626+
liveView.classList.remove('visible');
627+
628+
// restore transition on next frame
629+
onNextFrame(() => {
630+
liveView.classList.remove('notransition');
631+
});
632+
633+
} else { // if embed
634+
635+
// get live view link
636+
const link = createLink({
637+
dir: selectedFile.dir.split(','),
638+
file: selectedFile,
639+
openLive: true
640+
});
641+
642+
// open a new window with live view link
643+
window.open(link, '_blank');
644+
645+
}
631646

632647
});
633648

worker/client-channel.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55

66
// update worker name when updating worker
7-
const WORKER_NAME = 'codeit-worker-v555';
7+
const WORKER_NAME = 'codeit-worker-v556';
88

99

1010
// internal paths
@@ -74,7 +74,7 @@ function createResponse(data, type, status, cache) {
7474
'Content-Type': type
7575
};
7676

77-
if (!cache) headers['Cache-Control'] = 'public, max-age=0, must-revalidate';
77+
//if (!cache) headers['Cache-Control'] = 'public, max-age=0, must-revalidate';
7878

7979
// create Response from data
8080
const response = new Response(data, {

0 commit comments

Comments
 (0)