Skip to content

Commit a650eb1

Browse files
kroumaMatyáš KroupaMrRefactoring
authored
Swap form-data for formdata-node (MrRefactoring#333)
The newer library better supports modules and is written in TypeScript. The FormData interface is a drop-in replacement except for getHeaders(), but that didn't do anything useful, so it can be dropped. Closes MrRefactoring#327 Signed-off-by: Matyáš Kroupa <[email protected]> Co-authored-by: Matyáš Kroupa <[email protected]> Co-authored-by: Vladislav Tupikin <[email protected]>
1 parent df8e9d2 commit a650eb1

File tree

5 files changed

+15
-11
lines changed

5 files changed

+15
-11
lines changed

package-lock.json

+9
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@
7171
"vitest": "^2.1.8"
7272
},
7373
"dependencies": {
74-
"axios": "^1.7.9",
75-
"form-data": "^4.0.1",
76-
"tslib": "^2.8.1"
74+
"axios": "^1.7.7",
75+
"formdata-node": "^6.0.3",
76+
"tslib": "^2.7.0"
7777
}
7878
}

src/serviceDesk/serviceDesk.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as FormData from 'form-data';
1+
import { FormData } from 'formdata-node';
22
import * as Models from './models';
33
import * as Parameters from './parameters';
44
import { Callback } from '../callback';
@@ -124,7 +124,6 @@ export class ServiceDesk {
124124
headers: {
125125
'X-Atlassian-Token': 'no-check',
126126
'Content-Type': 'multipart/form-data',
127-
...formData.getHeaders?.(),
128127
},
129128
data: formData,
130129
};

src/version2/issueAttachments.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
// @ts-expect-error Wrong form data typings
2-
import FormData from 'form-data';
1+
import { FormData } from 'formdata-node';
32
import * as Models from './models';
43
import * as Parameters from './parameters';
54
import { Callback } from '../callback';
@@ -434,7 +433,6 @@ export class IssueAttachments {
434433
headers: {
435434
'X-Atlassian-Token': 'no-check',
436435
'Content-Type': 'multipart/form-data',
437-
...formData.getHeaders?.(),
438436
},
439437
data: formData,
440438
maxBodyLength: Infinity,

src/version3/issueAttachments.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
// @ts-expect-error Wrong form data typings
2-
import FormData from 'form-data';
1+
import { FormData } from 'formdata-node';
32
import * as Models from './models';
43
import * as Parameters from './parameters';
54
import { Callback } from '../callback';
@@ -434,7 +433,6 @@ export class IssueAttachments {
434433
headers: {
435434
'X-Atlassian-Token': 'no-check',
436435
'Content-Type': 'multipart/form-data',
437-
...formData.getHeaders?.(),
438436
},
439437
data: formData,
440438
maxBodyLength: Infinity,

0 commit comments

Comments
 (0)