Implemented A* algorithm and updated test cases #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kishan-Ved @czgdp1807 |
czgdp1807
requested changes
Jan 25, 2025
Comment on lines
+756
to
+762
| if algorithm == 'a_star_with_manhattan': | ||
| # A* with this implementation requires both source and target | ||
| if not target: | ||
| raise ValueError("Target must be specified for A* algorithm") | ||
|
|
||
| func = "_a_star_with_manhattan_" + graph._impl | ||
| return getattr(algorithms, func)(graph, source, target) |
There was a problem hiding this comment.
This is not needed. The logic below already handles this.
| @@ -293,7 +292,34 @@ def _test_shortest_paths_positive_edges(ds, algorithm): | |||
| graph.remove_edge('SLC', 'D') | |||
| graph.add_edge('D', 'SLC', -10) | |||
| assert raises(ValueError, lambda: shortest_paths(graph, 'bellman_ford', 'SLC')) | |||
|
|
|||
| def _test_a_star_manhattan(ds): | |||
There was a problem hiding this comment.
Suggested change
| def _test_a_star_manhattan(ds): | |
| def _test_a_star_manhattan(ds): |
It's a path setting issue in VSCode. You need to add PATH to your conda environment headers in VSCode settings. |
|
I'm currently working on this along with publishing a research paper. I'll get it done ASAP sir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs or Relevant literature
fixes #486
https://github.com/codezonediitj/pydatastructs/pull/283/files
https://github.com/codezonediitj/pydatastructs/pull/301/files
Brief description of what is fixed or changed
1.implemented a star algorithm with the help of Manhattan heustric and took reference from the Wikipedia
2.took reference from the Dijkstra and bellman ford algorithm for test cases and code writing
Other comments