Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Issues with New Landing Page #31

Closed
manassehkatz opened this issue Jan 30, 2020 · 5 comments
Closed

Minor Issues with New Landing Page #31

manassehkatz opened this issue Jan 30, 2020 · 5 comments
Labels
area: frontend Changes to front-end code meta: good first issue Good for newcomers

Comments

@manassehkatz
Copy link

1 - What does "focusing around the answer." mean? Might need to change the language to clarify.

2 - "big - and little questions" should probably be "big - and little - questions"

3 - The section with the announcements list signup ends up (on my screen anyway, but both Firefox & Chrome consistently) with the mailto link text split onto two lines - hyphenated. Source looks fine, it is simply a too-small box so it decides to split on the hyphen because there is one in a reasonable place.

4 - Github logo in upper right is hard to see - light color on light background.

@ranolfi
Copy link
Member

ranolfi commented Jan 30, 2020

@all: Item 4 addressed earlier 9417ca0 but still shows up incorrectly for @manassehkatz for some reason:
image

Looks alright from here:
image

We're trying to figure that out. Not a CDN issue, perhaps browser caching or something.

@manassehkatz
Copy link
Author

Tested via changing server index.html to point to logo-github-black.png and that works fine in all browsers/systems that I tried, as does the github staging page. Reverted change on server and goes back to previous inconsistent behavior. Suspect some sort of Cloudflare cachine problem.

@ranolfi
Copy link
Member

ranolfi commented Jan 30, 2020

Be advised, item 4 seems to be resolved for @manassehkatz. Most likely a caching issue indeed.

Items 1-3 still pending.

@manassehkatz
Copy link
Author

Be advised, item 4 seems to be resolved for @manassehkatz. Most likely a caching issue indeed.

Confirmed resolved.

@mattjbrent mattjbrent added area: frontend Changes to front-end code meta: good first issue Good for newcomers labels Jan 31, 2020
@mattjbrent mattjbrent pinned this issue Jan 31, 2020
@mattjbrent
Copy link
Collaborator

Duplicate of #34

These changes get resolved by changes in 34 which is pending MR merge.

@mattjbrent mattjbrent unpinned this issue Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Changes to front-end code meta: good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants