-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First header doesn't show #55
Comments
@galegosimpatico There has been a new iteration of the landing page, can you reproduce the bug once again for it? |
I think this was an issue in classless headers being pasted to the page live (to the FAQ section), I suspect it'd still happen, but I don't know anymore if that's a real problem or not. |
I can't see any question pasted to the FAQ. There's no reason to work on this if there is no longer a FAQ. |
@galegosimpatico The new site can be accessed at https://codidact.github.io/landing-page/ and there's been a re-design for the FAQ section. Can you check/validate if the problem is fixed |
Oh, that's a sweet redesign!
Do you add content live to that page? Because if not, or it gets added with styles, then this is #55 is no longer and issue and meets some immediate close. |
The FAQs are loaded from the resource https://raw.githubusercontent.com/codidact/docs/master/User-Help/CodidactMainPageFAQ.md and then parsed with js and is put into the respective layouts |
Fixed with new redesign #74 |
Describe the bug
H1 tags don't show. DOM isn't honored and screenreaders and HTML parsers potentially show a different output than a visual web browser.
To Reproduce
N/A, discovered because of #53 and demonstrated attaching pic in #53 (comment). Contrast that vs pics https://user-images.githubusercontent.com/53513496/90967832-38371880-e4e5-11ea-8fbf-746cdbbe4dce.jpg and https://user-images.githubusercontent.com/53513496/90967836-4127ea00-e4e5-11ea-920b-17a21b6d8f0c.jpg of comment #53 (comment) or vs pic https://user-images.githubusercontent.com/53513496/90967121-0d47c700-e4db-11ea-9573-dc0a62d8dcfc.png of #53 (comment).
Expected behavior
H1 was printed on my Opera, like H2 and H3. BTW H2 and H3 look the same, would report that eventually. In the "reader view available" of my phone it was printed as expected.
Screenshots
Aye, see #53 (comment) and pics https://user-images.githubusercontent.com/53513496/90967832-38371880-e4e5-11ea-8fbf-746cdbbe4dce.jpg and https://user-images.githubusercontent.com/53513496/90967836-4127ea00-e4e5-11ea-920b-17a21b6d8f0c.jpg of comment #53 (comment) or vs pic https://user-images.githubusercontent.com/53513496/90967121-0d47c700-e4db-11ea-9573-dc0a62d8dcfc.png of #53 (comment).
Desktop:
Smartphone:
The text was updated successfully, but these errors were encountered: