fix(core): ensure modules have unique names (#120)

Author: potb

src/core/checkUniqueModuleNames.ts

@@ -17,12 +17,15 @@ const createEnvForModule = (constantName: string) =>
       return acc;
     }, {});
 
-export const createAllModules = async (
-  modules: Record<string, ModuleCreator>,
-): Promise<CreatedModule[]> => {
+export const createAllModules = async (modules: ModuleCreator[]): Promise<CreatedModule[]> => {
+  const uniqueModuleNames = new Set(modules.map((module) => module.name));
+  if (uniqueModuleNames.size !== modules.length) {
+    throw new Error('Found duplicate module names');
+  }
+
   const createdModules: CreatedModule[] = [];
 
-  for (const { name, factory } of Object.values(modules)) {
+  for (const { name, factory } of modules) {
     const moduleConstantName = constantCase(name);
     const env = createEnvForModule(moduleConstantName);
     const module = await factory({ env });

src/core/createEnvForModule.ts

@@ -4,7 +4,21 @@ import { createAllModules } from './core/createEnvForModule';
 import { env } from './core/env';
 import { getIntentsFromModules } from './core/getIntentsFromModules';
 import { loadModules } from './core/loadModules';
-import { modules } from './modules/modules';
+import { coolLinksManagement } from './modules/coolLinksManagement/coolLinksManagement.module';
+import { fart } from './modules/fart/fart.module';
+import { fixEmbedTwitterVideo } from './modules/fixEmbedTwitterVideo/fixEmbedTwitterVideo.module';
+import { quoiFeur } from './modules/quoiFeur/quoiFeur.module';
+import { recurringMessage } from './modules/recurringMessage/recurringMessage.module';
+import { voiceOnDemand } from './modules/voiceOnDemand/voiceOnDemand.module';
+
+const modules = [
+  fart,
+  voiceOnDemand,
+  coolLinksManagement,
+  quoiFeur,
+  recurringMessage,
+  fixEmbedTwitterVideo,
+];
 
 const createdModules = await createAllModules(modules);