fix: handle emojis properly (#105)

Author: potb

src/__tests__/regex.spec.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it } from 'vitest';
 
+import { EMOJI } from '../helpers/emoji';
 import { isASocialNetworkUrl, removeEmoji, removeMarkdown } from '../helpers/regex.helper';
 
 describe('Helpers: Regex', () => {
@@ -17,7 +18,7 @@ describe('Helpers: Regex', () => {
   });
   describe('Rule: removeEmoji should remove all emojis from a string', () => {
     it('removeEmoji() should remove all emojis from a string', () => {
-      const text = '👋 Hello, World!<:SpongebobMock:1136008737669259407>';
+      const text = `${EMOJI.WAVE} Hello, World!<:SpongebobMock:1136008737669259407>`;
       const result = removeEmoji(text);
       expect(result).toBe(' Hello, World!');
     });

src/helpers/emoji.ts

@@ -0,0 +1,36 @@
+export const EMOJI = {
+  A: '🇦',
+  B: '🇧',
+  C: '🇨',
+  D: '🇩',
+  E: '🇪',
+  F: '🇫',
+  G: '🇬',
+  H: '🇭',
+  I: '🇮',
+  J: '🇯',
+  K: '🇰',
+  L: '🇱',
+  M: '🇲',
+  N: '🇳',
+  O: '🇴',
+  P: '🇵',
+  Q: '🇶',
+  R: '🇷',
+  S: '🇸',
+  T: '🇹',
+  U: '🇺',
+  V: '🇻',
+  W: '🇼',
+  X: '🇽',
+  Y: '🇾',
+  Z: '🇿',
+  MUTED: '🔇',
+  PUT_LITTER_IN_ITS_PLACE: '🚮',
+  DASH: '💨',
+  WAVE: '👋',
+  OK: '✅',
+  NOT_OK: '❌',
+} as const;
+
+export type Emoji = (typeof EMOJI)[keyof typeof EMOJI];

src/modules/coolLinksManagement/coolLinksManagement.module.ts

@@ -3,6 +3,7 @@ import ogs from 'open-graph-scraper';
 import { z } from 'zod';
 
 import { createModule } from '../../core/createModule';
+import { EMOJI } from '../../helpers/emoji';
 import { isASocialNetworkUrl } from '../../helpers/regex.helper';
 import { getPageSummary } from './summarizeCoolPages';
 import { getVideoSummary } from './summarizeCoolVideos';
@@ -54,8 +55,8 @@ export const coolLinksManagement = createModule({
         return;
       }
 
-      await message.react('✅');
-      await message.react('❌');
+      await message.react(EMOJI.OK);
+      await message.react(EMOJI.NOT_OK);
 
       const url = detectedURLs[0];
       const threadName = await getThreadNameFromOpenGraph(url);

src/modules/fixEmbedTwitterVideo/fixEmbedTwitterVideo.module.ts

@@ -2,6 +2,7 @@ import { ActionRowBuilder, ButtonBuilder, ButtonStyle, MessageType } from 'disco
 import { z } from 'zod';
 
 import { createModule } from '../../core/createModule';
+import { EMOJI } from '../../helpers/emoji';
 import { resolveCatch } from '../../helpers/resolveCatch.helper';
 
 const FXTwitterResponseSchema = z.object({
@@ -109,13 +110,13 @@ export const fixEmbedTwitterVideo = createModule({
       const cancel = new ButtonBuilder()
         .setCustomId(deleteBotAnswerButtonId)
         .setLabel('Remove bot answer')
-        .setEmoji('🚮')
+        .setEmoji(EMOJI.PUT_LITTER_IN_ITS_PLACE)
         .setStyle(ButtonStyle.Primary);
 
       const ignore = new ButtonBuilder()
         .setCustomId(ignoreBotButtonsButtonId)
         .setLabel('Ignore bot buttons')
-        .setEmoji('💨')
+        .setEmoji(EMOJI.DASH)
         .setStyle(ButtonStyle.Primary);
 
       const row = new ActionRowBuilder<ButtonBuilder>().addComponents(cancel, ignore);

src/modules/quoiFeur/quoiFeur.helpers.ts

@@ -7,6 +7,8 @@ import {
 } from 'discord.js';
 
 import { cache } from '../../core/cache';
+import type { Emoji } from '../../helpers/emoji';
+import { EMOJI } from '../../helpers/emoji';
 import {
   removeEmoji,
   removeMarkdown,
@@ -20,16 +22,17 @@ const quoiDetectorRegex = /\bquoi\s*$/i;
 const endWithQuoi = (text: string) =>
   quoiDetectorRegex.test(removeNonASCII(removeEmoji(removePunctuation(removeMarkdown(text)))));
 
-const reactWith = async (message: Message, reactions: string[]) => {
+const reactWith = async (message: Message, reactions: Emoji[]) => {
   for (const reaction of reactions) {
     await message.react(reaction);
   }
 };
 
 const reactWithCoubeh = async (message: Message) =>
-  reactWith(message, ['🇨', '🇴', '🇺', '🇧', '🇪', '🇭', '🔇']);
+  reactWith(message, [EMOJI.C, EMOJI.O, EMOJI.U, EMOJI.B, EMOJI.E, EMOJI.H, EMOJI.MUTED]);
 
-const reactWithFeur = async (message: Message) => reactWith(message, ['🇫', '🇪', '🇺', '🇷']);
+const reactWithFeur = async (message: Message) =>
+  reactWith(message, [EMOJI.F, EMOJI.E, EMOJI.U, EMOJI.R]);
 
 export const reactOnEndWithQuoi = async (message: Message) => {
   if (!endWithQuoi(message.content)) return;