Skip to content

Commit 8285b9e

Browse files
committed
chore: rename scripts and workflows so they are more explicit (#106)
1 parent 47e63fb commit 8285b9e

File tree

4 files changed

+657
-17
lines changed

4 files changed

+657
-17
lines changed

.github/workflows/deployment.yaml

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
name: Deploy application
2+
13
on:
24
push:
35
branches:
@@ -16,6 +18,7 @@ concurrency:
1618

1719
jobs:
1820
deployment:
21+
name: Perform deployment
1922
runs-on: ubuntu-22.04
2023
permissions: read-all
2124

@@ -46,7 +49,7 @@ jobs:
4649
- name: Login to Heroku Container Registry
4750
run: heroku container:login
4851

49-
- name: Build Docker image for the bot
52+
- name: Build Docker image
5053
uses: docker/build-push-action@v5
5154
with:
5255
push: true
@@ -55,5 +58,5 @@ jobs:
5558
cache-from: type=gha
5659
cache-to: type=gha,mode=max
5760

58-
- name: Deploy the bot
61+
- name: Deploy Docker image
5962
run: heroku container:release worker --app codinglab-discord-bot

.github/workflows/integration.yaml

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Check Integration
1+
name: Check integration
22

33
on:
44
pull_request:
@@ -49,14 +49,14 @@ jobs:
4949
- name: Install dependencies
5050
run: pnpm install --frozen-lockfile
5151

52-
- name: Format project
53-
run: pnpm format
52+
- name: Check code formatting
53+
run: pnpm check:format
5454

55-
- name: Type-check project
56-
run: pnpm typecheck
55+
- name: Check code typing
56+
run: pnpm check:types
5757

58-
- name: Lint project
59-
run: pnpm lint
58+
- name: Check code linting
59+
run: pnpm check:lint
6060

6161
- name: Test project
6262
run: pnpm test

package.json

+6-4
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,11 @@
88
"scripts": {
99
"build": "tsup-node src/main.ts",
1010
"dev": "tsup-node src/main.ts --watch --on-success \"clear && node --enable-source-maps -r dotenv/config dist/main.js\"",
11-
"lint": "eslint src --report-unused-disable-directives",
12-
"format": "prettier -c src",
13-
"typecheck": "tsc --noEmit",
14-
"test": "vitest"
11+
"test": "vitest",
12+
"check:lint": "eslint src --report-unused-disable-directives",
13+
"check:format": "prettier -c src",
14+
"check:types": "tsc --noEmit",
15+
"check": "run-s check:*"
1516
},
1617
"dependencies": {
1718
"@keyv/redis": "2.7.1",
@@ -36,6 +37,7 @@
3637
"eslint-plugin-simple-import-sort": "10.0.0",
3738
"eslint-plugin-sonarjs": "0.21.0",
3839
"eslint-plugin-unused-imports": "3.0.0",
40+
"npm-run-all": "4.1.5",
3941
"prettier": "3.0.3",
4042
"tsup": "7.2.0",
4143
"type-fest": "4.4.0",

0 commit comments

Comments
 (0)