make delete a instance method (#75)

* make delete a instance method

* Update test_webhook.py

* Revert "Update test_webhook.py"

This reverts commit becbc2e.

* Revert "make delete a instance method"

This reverts commit 7775cd2.

* make delete() deprecated, introduce delete_webhook()

* Update CHANGELOG.md

* name instance method delete also

* Revert "name instance method delete also"

This reverts commit 505f8d6.

* Update test_webhook.py

* Update webhook.py

* lint

* Update webhook.py

* modify comment and CHANGELOG

Author: howard-at-cb

CHANGELOG.md

@@ -4,8 +4,12 @@
 
 ### Added
 
-- `ExternalAddress` derived `Address` class.
+- Add `Webhook.delete_webhook` instance method to delete a webhook instance.
+- Add `ExternalAddress` derived `Address` class.
 
+### Deprecated
+
+- Deprecate `Webhook.delete` static method in `Webhook` which deletes a webhook by its ID.
 
 ## [0.13.0] - 2024-12-19
 
@@ -14,7 +18,7 @@
 - Add support for fetching address reputation
   - Add `reputation` method to `Address` to fetch the reputation of the address.
 - Add support for registering, updating, and listing smart contracts that are
-deployed external to CDP.
+  deployed external to CDP.
 - Add `network_id` to `WalletData` so that it is saved with the seed data and surfaced via the export function
 - Add ability to import external wallets into CDP via a BIP-39 mnemonic phrase, as a 1-of-1 wallet
 - Add ability to import WalletData files exported by the NodeJS CDP SDK
@@ -42,7 +46,7 @@ deployed external to CDP.
 ### Added
 
 - Add support for funding wallets (Alpha feature release)
-    - Must reach out to CDP SDK Discord channel to be considered for this feature.
+  - Must reach out to CDP SDK Discord channel to be considered for this feature.
 - Added create and update feature for `SmartContractEventActivity` webhook and its related event type filter.
 
 ### Fixed
@@ -88,7 +92,7 @@ deployed external to CDP.
 ### Changed
 
 - Make faucet transactions async i.e. using `faucet_tx.wait()` to wait for the transaction to be confirmed.
-    - This will make the SDK more consistent and make faucet transactions more reliable.
+  - This will make the SDK more consistent and make faucet transactions more reliable.
 
 ## [0.0.9] - 2024-10-29
 

cdp/webhook.py

@@ -1,10 +1,15 @@
+import warnings
 from collections.abc import Iterator
 
 from cdp.cdp import Cdp
 from cdp.client.models.create_webhook_request import CreateWebhookRequest
 from cdp.client.models.update_webhook_request import UpdateWebhookRequest
 from cdp.client.models.webhook import Webhook as WebhookModel
-from cdp.client.models.webhook import WebhookEventFilter, WebhookEventType, WebhookEventTypeFilter
+from cdp.client.models.webhook import (
+    WebhookEventFilter,
+    WebhookEventType,
+    WebhookEventTypeFilter,
+)
 from cdp.client.models.webhook_list import WebhookList
 
 
@@ -143,9 +148,25 @@ def delete(webhook_id: str) -> None:
         Args:
             webhook_id (str): The ID of the webhook to delete.
 
+        Deprecated:
+            This static method is deprecated. Please use the instance method instead:
+            webhook_instance.delete_webhook()
+
         """
+        warnings.warn(
+            "This static method is deprecated. Please use the instance method instead: webhook_instance.delete_webhook()",
+            DeprecationWarning,
+            stacklevel=2,
+        )
         Cdp.api_clients.webhooks.delete_webhook(webhook_id)
 
+    def delete_webhook(self) -> None:
+        """Delete this webhook.
+
+        This method deletes the current webhook instance from the system.
+        """
+        Cdp.api_clients.webhooks.delete_webhook(self.id)
+
     def update(
         self,
         notification_uri: str | None = None,

tests/test_webhook.py

@@ -93,3 +93,16 @@ def test_webhook_update(mock_api_clients, webhook_factory):
     assert isinstance(updated_webhook, Webhook)
     assert updated_webhook.notification_uri == new_notification_uri
     assert updated_webhook.id == webhook.id
+
+
+@patch("cdp.Cdp.api_clients")
+def test_webhook_instance_delete(mock_api_clients, webhook_factory):
+    """Test Webhook instance delete method."""
+    # Create a webhook instance using the factory
+    webhook = Webhook(model=webhook_factory(webhook_id="webhook-123"))
+
+    # Call delete on the webhook instance
+    webhook.delete_webhook()
+
+    # Verify the API client was called with the correct webhook ID
+    mock_api_clients.webhooks.delete_webhook.assert_called_once_with("webhook-123")