Skip to content

Commit be5d376

Browse files
authored
fix(v0.10.1): Fix faucet transaction link (#40)
This fixes the faucet transaction method `transaction_link` to return the transaction link instead of the transaction hash. This adds a unit test to ensure this is set properly.
1 parent 7c1024f commit be5d376

6 files changed

+9
-5
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
## Unreleased
44

5+
## [0.10.1] - 2024-10-31
6+
- Fix Faucet transaction_link to return the correct transaction link instead of transaction hash.
7+
58
## [0.10.0] - 2024-10-31
69

710
### Changed

cdp/__version__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = "0.10.0"
1+
__version__ = "0.10.1"

cdp/faucet_transaction.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ def transaction_link(self) -> str:
6767
str: The transaction link.
6868
6969
"""
70-
return self.transaction.transaction_hash
70+
return self.transaction.transaction_link
7171

7272
@property
7373
def status(self) -> str:

docs/conf.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
project = 'CDP SDK'
1616
author = 'Coinbase Developer Platform'
17-
release = '0.10.0'
17+
release = '0.10.1'
1818

1919
# -- General configuration ---------------------------------------------------
2020
# https://www.sphinx-doc.org/en/master/usage/configuration.html#general-configuration

pyproject.toml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[project]
22
name = "cdp-sdk"
3-
version = "0.10.0"
3+
version = "0.10.1"
44
description = "CDP Python SDK"
55
readme = "README.md"
66
authors = [{name = "John Peterson", email = "[email protected]"}]
@@ -141,4 +141,4 @@ line-ending = "auto"
141141
known-first-party = ["cdp"]
142142

143143
[tool.coverage.run]
144-
omit = ["cdp/client/*"]
144+
omit = ["cdp/client/*"]

tests/test_faucet_transaction.py

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ def test_faucet_tx_initialization(faucet_transaction_factory):
1111

1212
assert isinstance(faucet_transaction, FaucetTransaction)
1313
assert faucet_transaction.transaction_hash == "0xtransactionhash"
14+
assert faucet_transaction.transaction_link == "https://sepolia.basescan.org/tx/0xtransactionlink"
1415
assert faucet_transaction.network_id == "base-sepolia"
1516
assert faucet_transaction.address_id == "0xdestination"
1617
assert faucet_transaction.status.value == "complete"

0 commit comments

Comments
 (0)